[DTrace-devel] [PATCH v3 04/19] memcpy: bounds-check
Nick Alcock
nick.alcock at oracle.com
Thu Mar 24 18:24:30 UTC 2022
This FIXME is pretty easy to implement.
Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
---
libdtrace/dt_cg.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
index ffbe5e95670f..2c82ee9eb67b 100644
--- a/libdtrace/dt_cg.c
+++ b/libdtrace/dt_cg.c
@@ -821,6 +821,8 @@ dt_cg_trace(dt_irlist_t *dlp _dt_unused_, dt_regset_t *drp _dt_unused_,
static void
dt_cg_memcpy(dt_irlist_t *dlp, dt_regset_t *drp, int dst, int src, size_t size)
{
+ uint_t lbl_ok = dt_irlist_label(dlp);
+
if (dt_regset_xalloc_args(drp) == -1)
longjmp(yypcb->pcb_jmpbuf, EDT_NOREG);
@@ -829,8 +831,13 @@ dt_cg_memcpy(dt_irlist_t *dlp, dt_regset_t *drp, int dst, int src, size_t size)
emit(dlp, BPF_MOV_REG(BPF_REG_3, src));
dt_regset_xalloc(drp, BPF_REG_0);
emit(dlp, BPF_CALL_HELPER(BPF_FUNC_probe_read));
+
+ emit(dlp, BPF_BRANCH_IMM(BPF_JEQ, BPF_REG_0, 0, lbl_ok));
+ dt_cg_probe_error(yypcb, DT_LBL_NONE, DTRACEFLT_BADADDR, 0);
+ emitl(dlp, lbl_ok,
+ BPF_NOP());
+
dt_regset_free_args(drp);
- /* FIXME: check BPF_REG_0 for error? */
dt_regset_free(drp, BPF_REG_0);
}
--
2.35.1.261.g8402f930ba.dirty
More information about the DTrace-devel
mailing list