[DTrace-devel] [PATCH] Reunite dt_cg_subr_speculation() and its comment
eugene.loh at oracle.com
eugene.loh at oracle.com
Thu Mar 17 18:08:17 UTC 2022
From: Eugene Loh <eugene.loh at oracle.com>
When patch 5f8c4107a "Add support for index() subroutine"
was applied, somehow the new function dt_cg_subr_index() was inserted
between dt_cg_subr_speculation() and the comment block describing (and
immediately preceding) it. Subsequent patches only increased the
separation. Move the comment block back to the function.
Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
---
libdtrace/dt_cg.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
index 89e4f1fc..14222ec5 100644
--- a/libdtrace/dt_cg.c
+++ b/libdtrace/dt_cg.c
@@ -3400,11 +3400,6 @@ dt_cg_subr_getminor(dt_node_t *dnp, dt_irlist_t *dlp, dt_regset_t *drp)
emit(dlp, BPF_ALU64_IMM(BPF_AND, dnp->dn_reg, 0xfffff));
}
-/*
- * Get and return a new speculation ID. These are unallocated entries in the
- * specs map, obtained by calling dt_speculation(). Return zero if none is
- * available. TODO: add a drop in this case?
- */
static void
dt_cg_subr_index(dt_node_t *dnp, dt_irlist_t *dlp, dt_regset_t *drp)
{
@@ -3730,6 +3725,11 @@ dt_cg_subr_rindex(dt_node_t *dnp, dt_irlist_t *dlp, dt_regset_t *drp)
TRACE_REGSET(" subr-rindex:End ");
}
+/*
+ * Get and return a new speculation ID. These are unallocated entries in the
+ * specs map, obtained by calling dt_speculation(). Return zero if none is
+ * available. TODO: add a drop in this case?
+ */
static void
dt_cg_subr_speculation(dt_node_t *dnp, dt_irlist_t *dlp, dt_regset_t *drp)
{
--
2.18.4
More information about the DTrace-devel
mailing list