[DTrace-devel] [PATCH v2 05/17] alloca: new bad-size fault

[Nick Alcock]

On 15 Mar 2022, Eugene Loh via DTrace-devel said:

> The files need copyright years updated.
>
> Should DTRACEFLT_BADSIZE be listed in libdtrace/unistd.d ?
>
> Should there be a test?  E.g. checking arg4 to ERROR?  Or is there one in a subsequent patch?  Something like 
> test/unittest/error/tst.DTRACEFLT_BADSIZE.d .

We have several tests that check this, but none of them work until much
later, so they don't get updated until later patches.

> How does any corresponding documentation change need to be tracked?  E.g. adding this new fault to
> https://docs.oracle.com/en/operating-systems/oracle-linux/dtrace-guide/dt_prov.html#dt_error_prov

I didn't think of that at all. (Honestly I'd forgotten we provided
explicit documentation of faults.)

We probably want to adjust the alloca docs to note the new constraints
around alloca (no use of the same variable for both alloca and
non-alloca; perhaps document no assignment of ternaries that have
maybe-alloca-or-maybe-not to variables, or perhaps not, it's rather
obscure.)