[DTrace-devel] [PATCH] Remove @@xfail markers from tests that should pass with assoc support

Eugene Loh eugene.loh at oracle.com
Thu Mar 10 19:58:33 UTC 2022


Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
I'll assume runtest.sh vetted these.
But why is this not squashed back into the assoc patch?

On 3/10/22 2:35 PM, Kris Van Hees via DTrace-devel wrote:
> Copyright years will be updated before I commit, so no need to point those out.
>
> On Thu, Mar 10, 2022 at 02:09:40PM -0500, Kris Van Hees via DTrace-devel wrote:
>> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
>> ---
>>   test/demo/intro/rwtime.d                        | 1 -
>>   test/unittest/arrays/tst.basic1.d               | 1 -
>>   test/unittest/arrays/tst.basic2.d               | 1 -
>>   test/unittest/arrays/tst.basic3.d               | 1 -
>>   test/unittest/arrays/tst.basic4.d               | 1 -
>>   test/unittest/arrays/tst.basic5.d               | 1 -
>>   test/unittest/arrays/tst.basic6.d               | 1 -
>>   test/unittest/dtrace-util/tst.InvalidModule4.sh | 1 -
>>   test/unittest/funcs/tst.basename.d              | 1 -
>>   test/unittest/funcs/tst.hton.d                  | 1 -
>>   test/unittest/scalars/tst.selfarray.d           | 1 -
>>   test/unittest/sizeof/tst.SizeofString1.d        | 1 -
>>   test/unittest/struct/tst.StructAssoc.d          | 1 -
>>   test/unittest/union/tst.UnionAssoc.d            | 1 -
>>   14 files changed, 14 deletions(-)
>>
>> diff --git a/test/demo/intro/rwtime.d b/test/demo/intro/rwtime.d
>> index 0112c7c3..2cf2c717 100644
>> --- a/test/demo/intro/rwtime.d
>> +++ b/test/demo/intro/rwtime.d
>> @@ -5,7 +5,6 @@
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>>   
>> -/* @@xfail: dtv2 */
>>   /* @@trigger: readwholedir */
>>   
>>   syscall::read:entry,
>> diff --git a/test/unittest/arrays/tst.basic1.d b/test/unittest/arrays/tst.basic1.d
>> index 7276c96c..60700973 100644
>> --- a/test/unittest/arrays/tst.basic1.d
>> +++ b/test/unittest/arrays/tst.basic1.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   /*
>>    * ASSERTION:
>> diff --git a/test/unittest/arrays/tst.basic2.d b/test/unittest/arrays/tst.basic2.d
>> index 00a36077..f92b6942 100644
>> --- a/test/unittest/arrays/tst.basic2.d
>> +++ b/test/unittest/arrays/tst.basic2.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   /*
>>    * ASSERTION:
>> diff --git a/test/unittest/arrays/tst.basic3.d b/test/unittest/arrays/tst.basic3.d
>> index 7974f801..9095196e 100644
>> --- a/test/unittest/arrays/tst.basic3.d
>> +++ b/test/unittest/arrays/tst.basic3.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   /*
>>    * ASSERTION:
>> diff --git a/test/unittest/arrays/tst.basic4.d b/test/unittest/arrays/tst.basic4.d
>> index 3e305606..8ff67da5 100644
>> --- a/test/unittest/arrays/tst.basic4.d
>> +++ b/test/unittest/arrays/tst.basic4.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   /*
>>    * ASSERTION:
>> diff --git a/test/unittest/arrays/tst.basic5.d b/test/unittest/arrays/tst.basic5.d
>> index f86439b9..5e757399 100644
>> --- a/test/unittest/arrays/tst.basic5.d
>> +++ b/test/unittest/arrays/tst.basic5.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   /*
>>    * ASSERTION:
>> diff --git a/test/unittest/arrays/tst.basic6.d b/test/unittest/arrays/tst.basic6.d
>> index fce8b75c..a227434f 100644
>> --- a/test/unittest/arrays/tst.basic6.d
>> +++ b/test/unittest/arrays/tst.basic6.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   /*
>>    * ASSERTION:
>> diff --git a/test/unittest/dtrace-util/tst.InvalidModule4.sh b/test/unittest/dtrace-util/tst.InvalidModule4.sh
>> index 72a0e86a..bb33b840 100755
>> --- a/test/unittest/dtrace-util/tst.InvalidModule4.sh
>> +++ b/test/unittest/dtrace-util/tst.InvalidModule4.sh
>> @@ -5,7 +5,6 @@
>>   # Licensed under the Universal Permissive License v 1.0 as shown at
>>   # http://oss.oracle.com/licenses/upl.
>>   #
>> -# @@xfail: dtv2
>>   
>>   ##
>>   #
>> diff --git a/test/unittest/funcs/tst.basename.d b/test/unittest/funcs/tst.basename.d
>> index 1a33a488..337baec1 100644
>> --- a/test/unittest/funcs/tst.basename.d
>> +++ b/test/unittest/funcs/tst.basename.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   #pragma D option quiet
>>   
>> diff --git a/test/unittest/funcs/tst.hton.d b/test/unittest/funcs/tst.hton.d
>> index 1b555b07..ad902b34 100644
>> --- a/test/unittest/funcs/tst.hton.d
>> +++ b/test/unittest/funcs/tst.hton.d
>> @@ -5,7 +5,6 @@
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>>   
>> -/* @@xfail: dtv2 */
>>   /* @@runtest-opts: -C */
>>   
>>   /*
>> diff --git a/test/unittest/scalars/tst.selfarray.d b/test/unittest/scalars/tst.selfarray.d
>> index b1cfaa32..10e1a76e 100644
>> --- a/test/unittest/scalars/tst.selfarray.d
>> +++ b/test/unittest/scalars/tst.selfarray.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   /*
>>    * ASSERTION:
>> diff --git a/test/unittest/sizeof/tst.SizeofString1.d b/test/unittest/sizeof/tst.SizeofString1.d
>> index 30b58b25..f120ce77 100644
>> --- a/test/unittest/sizeof/tst.SizeofString1.d
>> +++ b/test/unittest/sizeof/tst.SizeofString1.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   /*
>>    * ASSERTION: sizeof returns the size in bytes of any D expression or data
>> diff --git a/test/unittest/struct/tst.StructAssoc.d b/test/unittest/struct/tst.StructAssoc.d
>> index 4ed09c67..afed64f3 100644
>> --- a/test/unittest/struct/tst.StructAssoc.d
>> +++ b/test/unittest/struct/tst.StructAssoc.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   /*
>>    * ASSERTION:
>> diff --git a/test/unittest/union/tst.UnionAssoc.d b/test/unittest/union/tst.UnionAssoc.d
>> index f957c565..245354c7 100644
>> --- a/test/unittest/union/tst.UnionAssoc.d
>> +++ b/test/unittest/union/tst.UnionAssoc.d
>> @@ -4,7 +4,6 @@
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>> -/* @@xfail: dtv2 */
>>   
>>   /*
>>    * ASSERTION:
>> -- 
>> 2.34.1
>>
>>
>> _______________________________________________
>> DTrace-devel mailing list
>> DTrace-devel at oss.oracle.com
>> https://oss.oracle.com/mailman/listinfo/dtrace-devel
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel



More information about the DTrace-devel mailing list