[DTrace-devel] [PATCH 2/6] Partial revert of 279d7fe8

Kris Van Hees kris.van.hees at oracle.com
Tue Mar 8 05:51:53 UTC 2022


On Mon, Mar 07, 2022 at 06:27:05PM -0500, Eugene Loh via DTrace-devel wrote:
> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
> but...
> 
> On 3/7/22 2:49 PM, Kris Van Hees via DTrace-devel wrote:
> > diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
> > @@ -3237,7 +3235,7 @@ dt_cg_assoc_op(dt_node_t *dnp, dt_irlist_t *dlp, dt_regset_t *drp)
> >   			   BPF_NOP());
> >   #else
> >   		xyerror(D_UNKNOWN, "internal error -- no support for "
> > -			"translated types yet\n");
> > +			"associative arrays yet\n");
> >   #endif
> >   	}
> >   }
> This change looks unrelated and made obsolete by a subsequent patch anyhow. 
> Remove it?

I included it here because the partial revert results in the original patch
only applying to translated types.  If someone walks through the commits and
e.g. in a bisect ends with this commit, an appropriate error is shown when you
try to perform an operation on an associative array.



More information about the DTrace-devel mailing list