[DTrace-devel] [PATCH 1/6] Reflect that the dvars map is not just for TLS variable storage

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
though I'm confused by one thing...

On 3/7/22 2:49 PM, Kris Van Hees via DTrace-devel wrote:
> The 'dvars' BPF map is used for all dynamic variable storage.  While TLS
> variables are currently the only implemented type of dynamic variables,
> associative array elements will use this same storage area once they are
> fully implemented.
>
> diff --git a/libdtrace/dt_bpf.c b/libdtrace/dt_bpf.c
> @@ -218,10 +218,10 @@ populate_probes_map(dtrace_hdl_t *dtp, int fd)
>    * - dvars:	Dynamic variables map.  This is a global hash map indexed with
> - *		a unique numeric identifier for each variable per thread.  The
> - *		value of each element is sized to accomodate the largest thread
> - *		local ariable type found across all programsn the tracing
> - *		session..
> + *		a unique numeric identifier for each dynamic variable (thread
> + *		local variable or associative array element).  The value of
> + *		each element is sized to accomodate the largest value type
> + *		all programs in the tracing session.
The last sentence confuses me.  Maybe a missing word?  Plus, 
s/accomodate/accommodate/.  How about:
         The value size is the largest dynamic variable
         size across all programs in the tracing session.