[DTrace-devel] [PATCH 2/6] translators: procfs.d: rename projid_t

Eugene Loh eugene.loh at oracle.com
Fri Mar 4 20:28:18 UTC 2022


I'm not familiar with translators.  Is an observed bug fixed? How is 
that manifested in this commit?  Should there be a test?

On 3/2/22 8:44 AM, Nick Alcock via DTrace-devel wrote:
> The Linux kernel already has a type named projid_t, with a definition
> that conflicts with that in use (for an unused field) by this
> translator.  libctf correctly diagnoses this as a conflict (where
> libdtrace-ctf didn't): rename the type in the translator.
>
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>   libdtrace/procfs.d.in | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libdtrace/procfs.d.in b/libdtrace/procfs.d.in
> index b63ce2147b45..038cf69b593c 100644
> --- a/libdtrace/procfs.d.in
> +++ b/libdtrace/procfs.d.in
> @@ -50,7 +50,7 @@ typedef struct lwpsinfo {
>   } lwpsinfo_t;
>   
>   typedef id_t taskid_t;
> -typedef id_t projid_t;
> +typedef id_t dprojid_t;
>   typedef id_t poolid_t;
>   typedef id_t zoneid_t;
>   
> @@ -95,7 +95,7 @@ typedef struct psinfo {
>   	char pr_dmodel;			/* data model */
>   	char pr_pad2[3];
>   	taskid_t pr_taskid;		/* task id */
> -	projid_t pr_projid;		/* project id */
> +	dprojid_t pr_projid;		/* project id */
>   	int pr_nzomb;			/* number of zombie lwps (Linux: 0) */
>   	poolid_t pr_poolid;		/* pool id */
>   	zoneid_t pr_zoneid;		/* zone id */



More information about the DTrace-devel mailing list