[DTrace-devel] [PATCH 1/8 v3] Do not set NONALLOCA taint on VAR[IDX]

[Nick Alcock]

On 6 Jun 2022, Kris Van Hees via DTrace-devel told this:

> The logic for setting a NONALLOCA taint on an identifier for stores of
> non-alloca, non-literal-0 values in the DT_OP_LBRAC handling in
> dt_node_op2() is incorrect.  We are removing it with this patch.
> Further analysis is necessary to determine whether it can be applied to
> the underlying array variable identifier and how.

... looks good -- though I'm fairly sure I can make things misbehave
now, they were misbehaving before.

Reviewed-by: Nick Alcock <nick.alcock at oracle.com>

... but I'd better add a test to make this fail again. I bet we can now
have simultaneous alloca and nonalloca for the same variable by
assigning, say, alloca() to it in one probe and a literal 5 in another,
leading to a verifier failure.

I'm a bit surprised no tests are failing really :(