[DTrace-devel] [PATCH 16/20] modules: fix can-never-fail comparison

[Kris Van Hees]

On Wed, May 11, 2022 at 10:12:58PM +0100, Nick Alcock via DTrace-devel wrote:
> Spotted by GCC 11.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... and queued for dev

> ---
>  libdtrace/dt_module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libdtrace/dt_module.c b/libdtrace/dt_module.c
> index 656b39d18d57..990fb40ad7f2 100644
> --- a/libdtrace/dt_module.c
> +++ b/libdtrace/dt_module.c
> @@ -195,7 +195,7 @@ dt_module_init_elf(dtrace_hdl_t *dtp, dt_module_t *dmp)
>  	int fd, err, bits;
>  	size_t shstrs;
>  
> -	if (!dmp->dm_file) {
> +	if (!dmp->dm_file[0] == '\0') {
>  		dt_dprintf("failed to open ELF file for module %s: "
>  		    "no file name known\n", dmp->dm_name);
>  		return dt_set_errno(dtp, EDT_NOTLOADED);
> -- 
> 2.36.1.263.g194b774378.dirty
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel