[DTrace-devel] [PATCH 12/12] Add support for copyinstr() subroutine

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

In dt_cg_subr_copyinstr(), the TRACE_REGSET messages should refer to 
copyinstr rather than copyin.

There is a lot of code duplicated between
     dt_cg_subr_copyin()
     dt_cg_subr_copyinstr()
Might it be useful to consolidate that code and reuse that consolidation 
for both purposes?

In the tests
     test/unittest/funcs/copyinstr/tst.copyinstr-no-maxsize.d
     test/unittest/funcs/copyinstr/tst.copyinstr.d
there is a
      * SECTION: Actions and Subroutines/copyin()
I do not understand the utility of such comments, but in any case it 
would seem that s/copyin/copyinstr/.

The tests
     test/unittest/funcs/copyinstr/tst.copyinstr-no-maxsize.d
     test/unittest/funcs/copyinstr/tst.copyinstr.d
should check results as I think you're now doing with tst.copyin.d in 
the earlier copyin() patch.

Why does err.badsize.d have no .r file -- err.badaddr.d does!  The same 
question goes for the copyin patch.