[DTrace-devel] [PATCH 04/12] Fix the -xcpp option

[Kris Van Hees]

On Mon, Jul 18, 2022 at 09:54:27AM -0700, Eugene Loh wrote:
> On 7/18/22 11:04, Kris Van Hees wrote:
> 
> > On Mon, Jul 18, 2022 at 09:16:33AM -0700, Eugene Loh wrote:
> > 
> > > 2)  Even if we want something to take place at multiple sites, we can maintain
> > > that "something" in one place and then call it from however many places we
> > > want.
> > Yes, but e.g. creating an intermediary function just to do that seems a bit of
> > overkill.  It's a single statement that appers in two functions.
> 
> Yeah, but a slightly tricky statement (as demonstrated by the multiple lines
> of comments that presumably would also be maintained).

I don't think that is a convincing argument yet, but taking a closer look at
those two functions, there is so much further overlap that I do agree that
there is a point in creating an intermediary.  I'll adjust the patch
accordingly.