[DTrace-devel] [PATCH 05/12] Fix the -xctfpath option

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
though maybe it also makes sense for Nick to take a peek?

In the /dev/null case, is a core dump really what we want?  I realize 
this question might be out-of-scope for this particular patch, but if a 
core dump is not really the desired behavior, maybe it makes more sense 
to fix the core dump first and then deal with the -xctfpath test.

By the way, is that why the test is a .sh?  If there were no core dump, 
maybe the test could be simpler?  Some sort of err.ctfpath.d:
     /* @@runtest-opts: -xctfpath=/dev/null */
     BEGIN { exit(0); }

Regarding tst.ctfpath.sh, there is again a dangling tab (line with 
nothing other than a tab).  Also, why do you use "rm core" rather than 
just setting "ulimit -c 0"?

Should there also be a "positive" test?  I do not know what, but I 
imagine something like a tst.ctfpath.d:
     /* @@runtest-opts: -xctfpath=/lib/modules/$(uname 
-r)/kernel/vmlinux.ctfa */
     BEGIN { exit(0); }