[DTrace-devel] [PATCH 06/12] Fix the -xverbose option

[Eugene Loh]

Our discussion has been tied into the 04/12 -xcpp thread.  Again:

1)  I think we should not say -xverbose and -S are equivalent. E.g., the 
commit message to this -xverbose patch.

2)  I'm in favor of putting the code to maintain in one place, even if 
one chooses to invoke it from multiple call sites.

But all that is repetition.  In order to move forward:

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

On 7/15/22 20:16, Eugene Loh wrote:
> Now my message to the mail list is bouncing?
>
> On 7/15/22 20:07, Eugene Loh wrote:
>> Ah. Here is another argument against [PATCH 04/12] (the -xcpp patch): 
>> its solution is revised two patches later.
>>
>> The new solution -- which is to maintain the exact same code in two 
>> different places -- makes an even clearer case for the cmd/dtrace.c 
>> solution I proposed earlier.
>>
>> Specifically, for -xverbose, in cmd/dtrace.c's -x processing, just 
>> add the statement:
>>         if (strcmp(optarg, "verbose") == 0)
>>                 g_cflags |= DTRACE_C_DIFV;
>>
>> Or is there something more subtle I am missing to the commit 
>> message's claim that -xverbose and -S are "equivalent"?
>>