[DTrace-devel] [oracle/dtrace-utils] b2d25b: Clean up dtrace::: arg handling and testing

[euloh]

  Branch: refs/heads/dev
  Home:   https://github.com/oracle/dtrace-utils
  Commit: b2d25b17b16928b5aaa1cc9391915c74d42223a1
      https://github.com/oracle/dtrace-utils/commit/b2d25b17b16928b5aaa1cc9391915c74d42223a1
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2022-06-16 (Thu, 16 Jun 2022)

  Changed paths:
    M libdtrace/dt_prov_dtrace.c
    M test/unittest/variables/bvar/tst.arg0.d
    M test/unittest/variables/bvar/tst.arg1.d
    M test/unittest/variables/bvar/tst.arg2.d
    M test/unittest/variables/bvar/tst.arg3.d
    M test/unittest/variables/bvar/tst.arg4.d
    M test/unittest/variables/bvar/tst.arg5.d
    M test/unittest/variables/bvar/tst.arg6.d
    M test/unittest/variables/bvar/tst.arg7.d
    M test/unittest/variables/bvar/tst.arg8.d
    M test/unittest/variables/bvar/tst.arg9.d

  Log Message:
  -----------
  Clean up dtrace::: arg handling and testing

Currently, the dtrace provider trampoline sets probe arguments to the
values being passed in some function call.  However:

*)  The BEGIN and END probes have no arguments defined.  This
    point is documented explicitly.  The probe arguments are
    certainly not the arguments passed into internal functions
    BEGIN_probe() and END_probe() -- no such arguments are passed!

*)  The ERROR probe does have defined arguments, but they are
    set up in clause code, not in the trampoline.

Therefore, do not copy probe args in the dtrace-provider trampoline.
Just zero the BEGIN and END probe arguments.

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 2c49a224697f19a40b6253089ed7cfa1f29309d9
      https://github.com/oracle/dtrace-utils/commit/2c49a224697f19a40b6253089ed7cfa1f29309d9
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2022-07-11 (Mon, 11 Jul 2022)

  Changed paths:
    M libdtrace/dt_prov_syscall.c
    A test/unittest/syscall/tst.return_args.d
    A test/unittest/syscall/tst.return_args.r

  Log Message:
  -----------
  Fix syscall:::return args

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: cad6af29be35a136e39d7bc055cfa8e8e9f287db
      https://github.com/oracle/dtrace-utils/commit/cad6af29be35a136e39d7bc055cfa8e8e9f287db
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2022-07-11 (Mon, 11 Jul 2022)

  Changed paths:
    M libdtrace/dt_cg.c
    M libdtrace/dt_cg.h
    M libdtrace/dt_prov_fbt.c
    M libdtrace/dt_prov_pid.c
    M libdtrace/dt_pt_regs.h
    M test/unittest/fbtprovider/tst.return0.d
    A test/unittest/fbtprovider/tst.return0.r
    A test/unittest/fbtprovider/tst.return1.d
    A test/unittest/fbtprovider/tst.return1.r
    M test/unittest/pid/tst.ret1.d
    M test/unittest/pid/tst.ret2.d

  Log Message:
  -----------
  Fix fbt:::return and pid:::return arg1

Meanwhile, set fbt:::return arg0=-1 to indicate we do not know the
real value.

Also, remove the unused PT_REGS_BPF_*().

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: c2be27a79d84232b23f62083945269e6030f89a4
      https://github.com/oracle/dtrace-utils/commit/c2be27a79d84232b23f62083945269e6030f89a4
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2022-07-11 (Mon, 11 Jul 2022)

  Changed paths:
    M libdtrace/dt_dctx.h

  Log Message:
  -----------
  Tidy up a copyright notice

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


Compare: https://github.com/oracle/dtrace-utils/compare/48c0305ba8fe...c2be27a79d84