[DTrace-devel] [PATCH 3/7] Remove the long-orphaned DT_DISASM macro

[Kris Van Hees]

On Thu, Jun 24, 2021 at 09:42:43PM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... I will add to 'dev'

> ---
>  libdtrace/dt_dis.h | 22 +++++++---------------
>  1 file changed, 7 insertions(+), 15 deletions(-)
> 
> diff --git a/libdtrace/dt_dis.h b/libdtrace/dt_dis.h
> index 62b42016..740cdd56 100644
> --- a/libdtrace/dt_dis.h
> +++ b/libdtrace/dt_dis.h
> @@ -15,8 +15,13 @@ extern "C" {
>  #endif
>  
>  /*
> - * The following disassembler listings can be requested.  The values can be
> - * combined to select multiple listings.
> + * The following disassembler listings can be requested with -xdisasm=....
> + *    - After compilation and assembly of a clause function.
> + *    - After constructing a probe program.
> + *    - After linking in dependencies.
> + *    - After all processing, prior to loading the program.
> + * The values can be combined to select multiple listings.  The '-S' option
> + * must also be supplied in order for disassembler output to be generated.
>   */
>  #define DT_DISASM_OPT_CLAUSE		1
>  #define DT_DISASM_OPT_PROG		2
> @@ -52,19 +57,6 @@ extern "C" {
>  			dt_dis_difo((dp), (fp), (idp), (pdp), \
>  				    "final program"); \
>  	} while(0)
> -/*
> - * Macro to test whether a given disassembler bit is set in the dt_disasm
> - * bit-vector.  If the bit for listing 'l' is set, the D disassembler will be
> - * invoked for that specific listing.  The '-S' option must also be supplied in
> - * order for disassembler output to be generated.
> - *
> - * Supported listings are:
> - *	1	After compilation and assembly of a clause function.
> - *	2	After constructing a probe program.
> - *	3	After linking in dependencies.
> - *	4	After all processing, prior to loading the program.
> - */
> -#define	DT_DISASM(dtp, l)		((dtp)->dt_disasm & (1 << ((l) - 1)))
>  
>  extern void dt_dis_insn(uint_t i, const struct bpf_insn *instr, FILE *fp);
>  extern void dt_dis_program(dtrace_hdl_t *dtp, dtrace_prog_t *pgp, FILE *fp);
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel