[DTrace-devel] [PATCH v3] Add support for array/struct/union to trace()

[Kris Van Hees]

On Tue, Feb 01, 2022 at 01:53:48PM -0500, Eugene Loh via DTrace-devel wrote:
> I suppose one last thing.  The dt_cg.c code should probably add a comment
> explaining why align=2 -- that choice might otherwise strike a reader as
> rather baffling.

Sure.
> 
> On 2/1/22 1:50 PM, Eugene Loh wrote:
> > Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
> > 
> > But were you going to change the clp2() comment beyond "range 1-8" since
> > clp2() makes the effort to be more applicable than that limited range? 
> > In any case, the clp2() code movement should be eliminated entirely
> > since it isn't necessary at all any more with the align=2 approach.
> > 
> > Is the output in tst.array.r stable?  Or are only the first 7 bytes
> > ("dtrace\0") stable?  The current tst.array.r might work for a broad
> > range of cases, but strictly speaking it probably ought to be fixed. 
> > E.g., maybe add some .r.p file that does
> > sed 's/ 0: 64 74 72 61 63 65 00 .*  dtrace\..*/ 0: 64 74 72 61 63 65 00
> > 00 00 00 00 00 00 00 00 00  dtrace........../'
> > 
> > The additional tst.struct<n>.d tests are nice, but we often try to name
> > tests more meaningfully.  That would be easy enough to do here.  E.g.
> > tst.struct-int8.d and so on.
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel