[DTrace-devel] [oracle/dtrace-utils] 11cc63: bpf: fix linking of include/asm directory

Kris Van Hees noreply at github.com
Thu Dec 8 05:27:59 UTC 2022


  Branch: refs/heads/dev
  Home:   https://github.com/oracle/dtrace-utils
  Commit: 11cc63904e1a78bae55fda07d3a343cd9f751294
      https://github.com/oracle/dtrace-utils/commit/11cc63904e1a78bae55fda07d3a343cd9f751294
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M bpf/Build

  Log Message:
  -----------
  bpf: fix linking of include/asm directory

The bpf/Build file contained code to select the appropriate include
directory to link into the DTrace build directory hierarchy, but it
then happily overwrote that with a link to /usr/include/asm.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Nick Alcock <nick.alcock at oracle.com>


  Commit: ac9224a2587484a040306c753f1fb1af7cd7b903
      https://github.com/oracle/dtrace-utils/commit/ac9224a2587484a040306c753f1fb1af7cd7b903
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M cmd/dtrace.c
    M libdtrace/dt_handle.c
    M libdtrace/dt_printf.c

  Log Message:
  -----------
  cmd, libdtrace: fix potentially unsafe printf-like calls

GCC 12 flagged some calls to printf-style functions for using a dynamic
string as format without arguments.  If the dymanic string somehow can
be made to contain a substitution sequence (%<something>) this would be
unsafe.

Due to some special case handing for error strings ending in a newline
character, the default error, liberr, and drop strings are adjusted as
well.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: 6edf90bdf26fc58489904819149b22d0a1e211cf
      https://github.com/oracle/dtrace-utils/commit/6edf90bdf26fc58489904819149b22d0a1e211cf
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M GNUmakefile
    M cmd/Build
    R cmd/dtrace.1
    A cmd/dtrace.8
    M dtrace.spec

  Log Message:
  -----------
  man: fix manpage

The manpage is moved to section 8 (System Management Commands) since
that is more appropriate.  This also makes it no longer necessary to
handle the conflict with the dtrace manpage provided by systemtap for
its dtrace-lookalike utility.

The formatting macros have been updated to use the simpler (standard)
ones described in groff_man.

References to the Oracle Linux DTrace Guide have been updated.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: 0045dd7e3a730720048cafbfb1dac8143d3e2b46
      https://github.com/oracle/dtrace-utils/commit/0045dd7e3a730720048cafbfb1dac8143d3e2b46
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M include/dtrace/dif_defines.h

  Log Message:
  -----------
  Increase the maximum size of strstab

The strtab size was limited in the legacy version to 0x7fff.  This
was generally sufficient because of how the strtab was implemented.
Now that all strings used in a probe program are stored in a single
strtab (incl. probe description names), a higher limit is needed.

All string offsets (and strtab size calculations) are using ssize_t,
so we use SSIZE_MAX as the upper limit.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: e404f499695c994a7ef3665c5a233a9fec656d2f
      https://github.com/oracle/dtrace-utils/commit/e404f499695c994a7ef3665c5a233a9fec656d2f
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M libdtrace/dt_handle.c
    M libdtrace/dt_impl.h

  Log Message:
  -----------
  Introduce a 'raw' error reporting mechanism

The error handling mechanism between libdtrace and consumer front-ends
(like dtrace) only allowed the reporting of error messages related to
probing activity.  There is a need to allow libdtrace API functions
the ability to report error conditions to the consumer front-end.
Especially errors encountered while enabling probes can benefit from
this mechanism to report the issues.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: 1e6e48613946b23efe23a0c74edddfa4e4b03a5e
      https://github.com/oracle/dtrace-utils/commit/1e6e48613946b23efe23a0c74edddfa4e4b03a5e
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M include/port.h
    M libdtrace/dt_error.c

  Log Message:
  -----------
  Use symbol name for 'not supported' error codes

The kernel uprobes implementation uses ENOTSUPP to indicate that a
uprobe could not be enabled, but this error code is not listed with
a symbolic name in userspace header files.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: 7c655ca914e7291fcf0800d54c0564d518286400
      https://github.com/oracle/dtrace-utils/commit/7c655ca914e7291fcf0800d54c0564d518286400
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M libdtrace/dt_bpf.c
    M libdtrace/dt_provider_tp.c

  Log Message:
  -----------
  Report an error to the consumer if a probe cannot be enabled

Some probes (esp. uprobes) appear to be useable, but yet the kernel
tracing subsystem reports a failure when trying to enable the probe.
It need not be a fatal error (esp. when probing a set of probes based
on a wildcard specification), but it should get reported.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


Compare: https://github.com/oracle/dtrace-utils/compare/2151f82d7251...7c655ca914e7



More information about the DTrace-devel mailing list