[DTrace-devel] [PATCH 49/61] test: Add results file for err.resize2.d

[Eugene Loh]

On 8/2/22 08:08, Kris Van Hees wrote:

> On Fri, Jul 08, 2022 at 10:45:33AM -0400, eugene.loh--- via DTrace-devel wrote:
>> From: Eugene Loh <eugene.loh at oracle.com>
>>
>> The err.resize2.d test PASSes.  Since this is an err.* test, that
>> means that the D script fails.  It fails, however, not because the
>> aggsize limit was excessive (which is the point of the test) but
>> simply because there is not yet support for aggregation keys.
>>
>> Add a .r results file to ensure that if the D script fails,
>> it fails for the expected reason.
>>
>> The real point of the test is to check the manual resizing option.
>> For now, however, we settle for reasonable behavior vis-a-vis
>> support for aggregation keys.
>>
>> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
>> ---
>>   test/stress/buffering/err.resize2.d | 4 ++--
>>   test/stress/buffering/err.resize2.r | 3 +++
>>   2 files changed, 5 insertions(+), 2 deletions(-)
>>   create mode 100644 test/stress/buffering/err.resize2.r
>>
>> diff --git a/test/stress/buffering/err.resize2.d b/test/stress/buffering/err.resize2.d
>> index 60e6ae37..277ec6cc 100644
>> --- a/test/stress/buffering/err.resize2.d
>> +++ b/test/stress/buffering/err.resize2.d
>> @@ -1,10 +1,11 @@
>>   /*
>>    * Oracle Linux DTrace.
>> - * Copyright (c) 2006, Oracle and/or its affiliates. All rights reserved.
>> + * Copyright (c) 2006, 2022, Oracle and/or its affiliates. All rights reserved.
>>    * Licensed under the Universal Permissive License v 1.0 as shown at
>>    * http://oss.oracle.com/licenses/upl.
>>    */
>>   /* @@timeout: 500 */
>> +/* @@xfail: need support for aggregation keys */
>>   
>>   /*
>>    * ASSERTION:
>> @@ -14,7 +15,6 @@
>>    * SECTION: Buffers and Buffering/Buffer Resizing Policy;
>>    *	Options and Tunables/bufresize;
>>    *	Options and Tunables/aggsize
>> - *
>>    */
>>   
>>   #pragma D option quietresize=no
>> diff --git a/test/stress/buffering/err.resize2.r b/test/stress/buffering/err.resize2.r
>> new file mode 100644
>> index 00000000..7ebdf0da
>> --- /dev/null
>> +++ b/test/stress/buffering/err.resize2.r
>> @@ -0,0 +1,3 @@
>> +-- @@stderr --
>> +dtrace: script 'test/stress/buffering/err.resize2.d' matched 1 probe
>> +dtrace: could not enable tracing: failed to create BPF map 'aggs': Argument list too long
> I think we should map this error to something more useful?  E.g. the legacy
> version reported: Cannot allocate memory

Okay.  I would think that would be a separate patch, though.  So I just 
posted such a patch as well as a v2 (using the new message) of the 
current patch.

>> -- 
>> 2.18.4
>>
>>
>> _______________________________________________
>> DTrace-devel mailing list
>> DTrace-devel at oss.oracle.com
>> https://oss.oracle.com/mailman/listinfo/dtrace-devel