[DTrace-devel] [PATCH 34/61] Eliminate an unneeded instance of strsize

Kris Van Hees kris.van.hees at oracle.com
Tue Aug 2 12:07:48 UTC 2022


On Fri, Jul 08, 2022 at 10:45:18AM -0400, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... queued for dev

> ---
>  libdtrace/dt_cg.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
> index 5b2276b0..063ec113 100644
> --- a/libdtrace/dt_cg.c
> +++ b/libdtrace/dt_cg.c
> @@ -2731,14 +2731,13 @@ dt_cg_arglist(dt_ident_t *idp, dt_node_t *args, dt_irlist_t *dlp,
>  			emit(dlp,  BPF_ALU64_IMM(BPF_ADD, treg, size));
>  			tuplesize += size;
>  		} else if (dt_node_is_string(dnp)) {
> -			size_t	strsize = dtp->dt_options[DTRACEOPT_STRSIZE];
>  			uint_t	lbl_valid = dt_irlist_label(dlp);
>  
>  			if (dt_regset_xalloc_args(drp) == -1)
>  				longjmp(yypcb->pcb_jmpbuf, EDT_NOREG);
>  
>  			emit(dlp,  BPF_MOV_REG(BPF_REG_1, treg));
> -			emit(dlp,  BPF_MOV_IMM(BPF_REG_2, strsize + 1));
> +			emit(dlp,  BPF_MOV_IMM(BPF_REG_2, size + 1));
>  			emit(dlp,  BPF_MOV_REG(BPF_REG_3, BPF_REG_0));
>  			dt_cg_tstring_free(yypcb, dnp);
>  			dt_regset_free(drp, BPF_REG_0);
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel



More information about the DTrace-devel mailing list