[DTrace-devel] [PATCH] test: Fix error tag in test name

[Kris Van Hees]

On Tue, Feb 22, 2022 at 12:59:10PM -0500, eugene.loh--- via DTrace-devel wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> A number of err.D_*.d tests had the wrong error tag in the test
> name, which escaped detection for a long time because runtest.sh
> did not check the error tags.  A number of such cases were fixed.
> This appears to be the last case.  The test encounters D_SYNTAX,
> both in legacy DTrace on Linux and in the current version.  Rename
> the test appropriately.
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... and I am adding it to dev.

Good catch.

> ---
>  .../{err.D_UNKNOWN.badmemb.d => err.D_SYNTAX.badmemb.d}       | 4 ++--
>  test/unittest/offsetof/err.D_SYNTAX.badmemb.r                 | 2 ++
>  test/unittest/offsetof/err.D_UNKNOWN.badmemb.r                | 2 --
>  3 files changed, 4 insertions(+), 4 deletions(-)
>  rename test/unittest/offsetof/{err.D_UNKNOWN.badmemb.d => err.D_SYNTAX.badmemb.d} (80%)
>  create mode 100644 test/unittest/offsetof/err.D_SYNTAX.badmemb.r
>  delete mode 100644 test/unittest/offsetof/err.D_UNKNOWN.badmemb.r
> 
> diff --git a/test/unittest/offsetof/err.D_UNKNOWN.badmemb.d b/test/unittest/offsetof/err.D_SYNTAX.badmemb.d
> similarity index 80%
> rename from test/unittest/offsetof/err.D_UNKNOWN.badmemb.d
> rename to test/unittest/offsetof/err.D_SYNTAX.badmemb.d
> index d8015b41..c0bc0573 100644
> --- a/test/unittest/offsetof/err.D_UNKNOWN.badmemb.d
> +++ b/test/unittest/offsetof/err.D_SYNTAX.badmemb.d
> @@ -1,10 +1,10 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2022, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> -/* @@xfail: dtv2 */
> +
>  /*
>   * ASSERTION:
>   *
> diff --git a/test/unittest/offsetof/err.D_SYNTAX.badmemb.r b/test/unittest/offsetof/err.D_SYNTAX.badmemb.r
> new file mode 100644
> index 00000000..59386acf
> --- /dev/null
> +++ b/test/unittest/offsetof/err.D_SYNTAX.badmemb.r
> @@ -0,0 +1,2 @@
> +-- @@stderr --
> +dtrace: failed to compile script test/unittest/offsetof/err.D_SYNTAX.badmemb.d: [D_SYNTAX] line 22: syntax error near "vnode_t, v_no_such_member));"
> diff --git a/test/unittest/offsetof/err.D_UNKNOWN.badmemb.r b/test/unittest/offsetof/err.D_UNKNOWN.badmemb.r
> deleted file mode 100644
> index ff815ec0..00000000
> --- a/test/unittest/offsetof/err.D_UNKNOWN.badmemb.r
> +++ /dev/null
> @@ -1,2 +0,0 @@
> --- @@stderr --
> -dtrace: failed to compile script test/unittest/offsetof/err.D_UNKNOWN.badmemb.d: [D_SYNTAX] line 22: syntax error near "vnode_t, v_no_such_member));"
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel