[DTrace-devel] [PATCH] Rename members in dtrace_syminfo_t

[Kris Van Hees]

On Fri, Oct 08, 2021 at 03:59:52PM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> In patch "6f930f0341a6 Add support for BPF identifiers, functions, and maps"
> members of dtrace_syminfo_t were renamed.  Complete the remaining changes,
> in INCOMPATIBILITIES.  The required changes in tst.symbols.c are the subject
> of another patch.  Note that struct dt_symbol still has a member named
> dts_name that does not require renaming.
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

... and I will add it to dev.

Note that we really need to review that file and update it because it is
very out of touch with reality.

> ---
>  INCOMPATIBILITIES | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/INCOMPATIBILITIES b/INCOMPATIBILITIES
> index 52441d9a..035c3675 100644
> --- a/INCOMPATIBILITIES
> +++ b/INCOMPATIBILITIES
> @@ -105,9 +105,9 @@ bsearch()ing of these arrays.  (We no longer distinguish between initialized
>  data and bss sections.)
>  
>  The dtrace_syminfo_t type populated by dtrace_lookup_by_name() and
> -dtrace_lookup_by_addr() no longer guarantees population of its dts_id member:
> +dtrace_lookup_by_addr() no longer guarantees population of its id member:
>  for kernel symbols, it will always be zero.  In future a further API change may
> -require the caller to free the dts_name member: this will be signalled by its no
> +require the caller to free the name member: this will be signalled by its no
>  longer being declared const.
>  
>  The GElf_Sym parameter populated by dtrace_lookup_by_name() and
> @@ -115,7 +115,7 @@ dtrace_lookup_by_addr() no longer guarantees population of its st_name or
>  st_other fields, and the only thing guaranteed about st_shndx is SHN_UNDEF
>  versus !SHN_UNDEF (there is no guarantee that it will correspond to an actual
>  ELF section).  If you want the symbol name, you should use the
> -dtrace_syminfo.dts_name instead.  There is no guaranteed replacement for
> +dtrace_syminfo.name instead.  There is no guaranteed replacement for
>  st_other.
>  
>  dtrace_update() now returns an error value, like dtrace_go() and dtrace_stop().
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel