[DTrace-devel] [oracle/dtrace-utils] 4b8a00: test: Fix incomplete line in .x file

euloh noreply at github.com
Wed Apr 20 14:59:12 UTC 2022


  Branch: refs/heads/dev
  Home:   https://github.com/oracle/dtrace-utils
  Commit: 4b8a007f2e46a48f36e8b500cfce57cb09d24422
      https://github.com/oracle/dtrace-utils/commit/4b8a007f2e46a48f36e8b500cfce57cb09d24422
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2022-04-19 (Tue, 19 Apr 2022)

  Changed paths:
    M test/unittest/stack/tst.stack_fbt.x

  Log Message:
  -----------
  test: Fix incomplete line in .x file

A line in tst.stack_fbt.x had been put back mysteriously chopped off,
causing the script to fail and tst.stack_fbt.d and tst.stack3_fbt.d
to be skipped inadvertently.

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 9cd13c7355d9427edcc1a6bf1908bc852fe95ee7
      https://github.com/oracle/dtrace-utils/commit/9cd13c7355d9427edcc1a6bf1908bc852fe95ee7
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2022-04-19 (Tue, 19 Apr 2022)

  Changed paths:
    M test/unittest/dtrace-util/man.ListProbesWithModules
    R test/unittest/dtrace-util/tst.InvalidModule4.r
    R test/unittest/dtrace-util/tst.InvalidModule4.sh
    A test/unittest/dtrace-util/tst.ListProbesModuleClause.r
    A test/unittest/dtrace-util/tst.ListProbesModuleClause.sh
    A test/unittest/dtrace-util/tst.ListProbesModuleEmpty.r
    A test/unittest/dtrace-util/tst.ListProbesModuleEmpty.sh

  Log Message:
  -----------
  test: Fix -lm tests

Test tst.InvalidModule4.sh was introduced as part of the DTrace port to
Linux.  It assumed that including a predicate and clause would invalidate
the module name, but that is not the case.  Rather, the module name was not
recognized in the legacy port simply because the named module did not exist.

This ill-constructed test was XFAIL, but that annotation was lifted in
patch 9574434662d0
"Remove @@xfail markers from tests that should pass with assoc support",
leading to some test failures.  Note that there is no connection between
this test and associative support.

Remove the test.

Add a -lm test for nonexisting names to match corresponding "Empty" tests.

Also add a -lm test to confirm that including a predicate and clause does
not invalidate the module name.

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


Compare: https://github.com/oracle/dtrace-utils/compare/a24181dc606c...9cd13c7355d9



More information about the DTrace-devel mailing list