[DTrace-devel] [PATCH v4 02/10] cg: fault improvements

[Nick Alcock]

On 13 Apr 2022, Kris Van Hees said:

>> Do not use regset allocation in dt_cg_probe_error on the grounds that
>> spilling to the stack is pointless when the regs will all be thrown away
>> in any case, and will trigger BPF verifier errors if some of the regs
>> are not initialized, as is relatively likely in an error condition.
>> 
>> Also add an argument specifying whether the illegal value is actually
>> a register whose value should be printed.  (Cases which don't care
>> can just pass 0, 0).
>
> Can you move the DT_ISREG / DT_ISIMM macros I add in [05/10]  (alloca deref)
> here (and remove them from that patch) for consistency?  That makes it easier
> to read the code in knowing what the argument value is.

After much pro-forma whining about how this makes 0, 0 less easy to
read, I realised that there are only six of those in total, and not many
more after alloca goes in: *so* not worth worrying over.

Adjusted.