[DTrace-devel] [PATCH v4 01/10] alloca: track alloca()ed allocations

[Nick Alcock]

On 13 Apr 2022, Kris Van Hees uttered the following:

> Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

Thanks!

> ... except that there is a XXX in a comment that seems to imply there is
> some work left to be done.  Has this been done or found not needed, or
> should this be a TODO?
>
> See:
> 	/* XXX do we need to do alloca tainting here? try with structs */

I'm fairly sure I concluded that this was unnecessary: it's DT_TOK_DOT,
so the only way to get here is to start with a dereferenced struct (not
a pointer to one). And all the necessary work for alloca is done at
deref time, which has already happened.

When I wrote this comment, the whole "everything gets untainted on
deref" thing hadn't occurred to me.

(Comment removed.)