[DTrace-devel] [PATCH REVIEW 6/6] tests: fix two more trivially passing tests

Kris Van Hees kris.van.hees at oracle.com
Wed Sep 29 14:28:15 PDT 2021


Reviewed-by: Kris Van Hees (kris.van.hees at oracle.com>

... and I added it to the 'dev' branch already.

On Thu, Sep 09, 2021 at 12:13:45PM +0100, Nick Alcock wrote:
> These tests just need results regenerating to account for tiny spacing
> changes.
> 
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>  test/demo/intro/countdown.d |  1 -
>  test/demo/intro/countdown.r | 20 ++++++++++----------
>  test/demo/intro/counter.d   |  1 -
>  test/demo/intro/counter.r   | 24 ++++++++++++------------
>  4 files changed, 22 insertions(+), 24 deletions(-)
> 
> Why did the spacing change? Search me, but unless it changes between
> runs this should be worth doing.
> 
> diff --git a/test/demo/intro/countdown.d b/test/demo/intro/countdown.d
> index 490c52853afe..6a7769a60e40 100644
> --- a/test/demo/intro/countdown.d
> +++ b/test/demo/intro/countdown.d
> @@ -5,7 +5,6 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> -/* @@xfail: dtv2 */
>  /* @@trigger: none */
>  
>  dtrace:::BEGIN
> diff --git a/test/demo/intro/countdown.r b/test/demo/intro/countdown.r
> index 970ecd8117e9..cf58d51a006c 100644
> --- a/test/demo/intro/countdown.r
> +++ b/test/demo/intro/countdown.r
> @@ -1,14 +1,14 @@
>                     FUNCTION:NAME
> -                      :tick-1sec        10
> -                      :tick-1sec         9
> -                      :tick-1sec         8
> -                      :tick-1sec         7
> -                      :tick-1sec         6
> -                      :tick-1sec         5
> -                      :tick-1sec         4
> -                      :tick-1sec         3
> -                      :tick-1sec         2
> -                      :tick-1sec         1
> +                      :tick-1sec          10
> +                      :tick-1sec           9
> +                      :tick-1sec           8
> +                      :tick-1sec           7
> +                      :tick-1sec           6
> +                      :tick-1sec           5
> +                      :tick-1sec           4
> +                      :tick-1sec           3
> +                      :tick-1sec           2
> +                      :tick-1sec           1
>                        :tick-1sec   blastoff!                        
>  
>  -- @@stderr --
> diff --git a/test/demo/intro/counter.d b/test/demo/intro/counter.d
> index a513ca05b154..120283d82ae0 100644
> --- a/test/demo/intro/counter.d
> +++ b/test/demo/intro/counter.d
> @@ -5,7 +5,6 @@
>   * http://oss.oracle.com/licenses/upl.
>   */
>  
> -/* @@xfail: dtv2 */
>  /* @@trigger: none */
>  /* @@timeout: 12 */
>  
> diff --git a/test/demo/intro/counter.r b/test/demo/intro/counter.r
> index ea682625894c..39b5ffefb716 100644
> --- a/test/demo/intro/counter.r
> +++ b/test/demo/intro/counter.r
> @@ -1,17 +1,17 @@
>                     FUNCTION:NAME
> -                      :tick-1sec         1
> -                      :tick-1sec         2
> -                      :tick-1sec         3
> -                      :tick-1sec         4
> -                      :tick-1sec         5
> -                      :tick-1sec         6
> -                      :tick-1sec         7
> -                      :tick-1sec         8
> -                      :tick-1sec         9
> -                      :tick-1sec        10
> -                      :tick-1sec        11
> +                      :tick-1sec           1
> +                      :tick-1sec           2
> +                      :tick-1sec           3
> +                      :tick-1sec           4
> +                      :tick-1sec           5
> +                      :tick-1sec           6
> +                      :tick-1sec           7
> +                      :tick-1sec           8
> +                      :tick-1sec           9
> +                      :tick-1sec          10
> +                      :tick-1sec          11
>                        :tick-1sec 
> -                            :END        11
> +                            :END          11
>  
>  -- @@stderr --
>  dtrace: script 'test/demo/intro/counter.d' matched 4 probes
> -- 
> 2.33.0.256.gb827f06fa9
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel



More information about the DTrace-devel mailing list