[DTrace-devel] [oracle/dtrace-utils] ccbf8b: cg: fix calls to rand

Nick Alcock noreply at github.com
Wed Sep 29 14:17:43 PDT 2021


  Branch: refs/heads/dev
  Home:   https://github.com/oracle/dtrace-utils
  Commit: ccbf8bd0266448db172073349bc2197d5187a9c7
      https://github.com/oracle/dtrace-utils/commit/ccbf8bd0266448db172073349bc2197d5187a9c7
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2021-09-29 (Wed, 29 Sep 2021)

  Changed paths:
    M libdtrace/dt_cg.c

  Log Message:
  -----------
  cg: fix calls to rand

For many types of identifier, a di_id of 0 means "undefined".  But for
subrs, di_id 0 is DIF_SUBR_RAND, a valid (albeit currently
unimplemented) subr.

Fixes several assertion failures running the testsute.

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 01b22a1b50b9feedb08c34e16ad1b9bef119f606
      https://github.com/oracle/dtrace-utils/commit/01b22a1b50b9feedb08c34e16ad1b9bef119f606
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2021-09-29 (Wed, 29 Sep 2021)

  Changed paths:
    M test/unittest/dtrace-util/tst.APIVersion.d
    M test/unittest/dtrace-util/tst.APIVersion.r

  Log Message:
  -----------
  tests: fix API version test

This just needs results regeneration.

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 2015eb271f669a52ba0b9a581df75947b8713f8c
      https://github.com/oracle/dtrace-utils/commit/2015eb271f669a52ba0b9a581df75947b8713f8c
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2021-09-29 (Wed, 29 Sep 2021)

  Changed paths:
    M libdtrace/dt_probe.c
    M test/unittest/dtrace-util/tst.InvalidTraceID1.sh
    M test/unittest/dtrace-util/tst.InvalidTraceID3.sh
    M test/unittest/dtrace-util/tst.InvalidTraceID7.sh
    M test/unittest/dtrace-util/tst.ZeroProbeIdentifier.sh

  Log Message:
  -----------
  errors: invalid probe IDs should return EDT_BADID, as in v1

They were returning EDT_NOPROBE, causing several tests for -i to fail.

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 85ecfd9d68bba44b56a606e79f8ef5a43ecb7047
      https://github.com/oracle/dtrace-utils/commit/85ecfd9d68bba44b56a606e79f8ef5a43ecb7047
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2021-09-29 (Wed, 29 Sep 2021)

  Changed paths:
    M test/unittest/printa/tst.many.d

  Log Message:
  -----------
  tests: printa/tst.many.d is not relevant for DTrace based on BPF

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 8359ab81fa5eca54f499529ba91ac225eebce151
      https://github.com/oracle/dtrace-utils/commit/8359ab81fa5eca54f499529ba91ac225eebce151
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2021-09-29 (Wed, 29 Sep 2021)

  Changed paths:
    M test/unittest/usdt/tst.dlclose1.sh

  Log Message:
  -----------
  tests: fix usdt/tst.dlclose1.sh

This test fails purely because of a bufsize expansion message, since in
v2 the bufsize must be at least one page.

Boost the bufsize in the test to the largest likely page size (64KiB,
seen on AArch64) to quash the message.

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: f1d8646be43f392b1e4d5456498c8de9e955b132
      https://github.com/oracle/dtrace-utils/commit/f1d8646be43f392b1e4d5456498c8de9e955b132
  Author: Nick Alcock <nick.alcock at oracle.com>
  Date:   2021-09-29 (Wed, 29 Sep 2021)

  Changed paths:
    M test/demo/intro/countdown.d
    M test/demo/intro/countdown.r
    M test/demo/intro/counter.d
    M test/demo/intro/counter.r

  Log Message:
  -----------
  tests: fix two more trivially passing tests

These tests just need results regenerating to account for tiny spacing
changes.

Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


Compare: https://github.com/oracle/dtrace-utils/compare/8d2f51bb07f1...f1d8646be43f



More information about the DTrace-devel mailing list