[DTrace-devel] [oracle/dtrace-utils] 564c81: Fix data size for value copy in dt_cg_store_var()

Kris Van Hees noreply at github.com
Fri Sep 10 00:44:51 PDT 2021


  Branch: refs/tags/2.0.0-1.7
  Home:   https://github.com/oracle/dtrace-utils
  Commit: 564c81bcc91eb08f4be10f7944c22e79f17af763
      https://github.com/oracle/dtrace-utils/commit/564c81bcc91eb08f4be10f7944c22e79f17af763
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M libdtrace/dt_cg.c
    M libdtrace/dt_ident.c
    A test/unittest/codegen/tst.str_store_var.d
    A test/unittest/codegen/tst.str_store_var.r
    A test/unittest/variables/gvar/tst.str-size.d
    A test/unittest/variables/gvar/tst.str-size.r
    M test/unittest/variables/gvar/tst.undecl-offset.r
    A test/unittest/variables/lvar/tst.str-size.d
    A test/unittest/variables/lvar/tst.str-size.r

  Log Message:
  -----------
  Fix data size for value copy in dt_cg_store_var()

The size of the data to be copied in dt_cg_store_var() was determined
wrongly.  For strings constants we were copying the size of the string
constant even if that might be larger than the maximum string size.

The offsets for lvars and gvars was also not taking into account the
length prefix to be stored for each string value.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: 87d82aca8fc95e4c8e2d2c93756e98b767a65bcf
      https://github.com/oracle/dtrace-utils/commit/87d82aca8fc95e4c8e2d2c93756e98b767a65bcf
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M bpf/Build
    A bpf/strjoin.S
    M libdtrace/dt_bpf.c
    M libdtrace/dt_cg.c
    M libdtrace/dt_dlibs.c
    A test/unittest/codegen/tst.dfunc_reg_leak.d
    A test/unittest/codegen/tst.dfunc_reg_leak.r
    A test/unittest/codegen/tst.tstring_leak.d
    A test/unittest/codegen/tst.tstring_leak.r
    A test/unittest/codegen/tst.tstring_leak2.d
    A test/unittest/codegen/tst.tstring_leak2.r
    M test/unittest/dif/strjoin.d
    A test/unittest/funcs/strjoin/tst.strjoin-capped-size-2.d
    A test/unittest/funcs/strjoin/tst.strjoin-capped-size-2.r
    A test/unittest/funcs/strjoin/tst.strjoin-capped-size-3.d
    A test/unittest/funcs/strjoin/tst.strjoin-capped-size-3.r
    A test/unittest/funcs/strjoin/tst.strjoin-capped-size.d
    A test/unittest/funcs/strjoin/tst.strjoin-capped-size.r
    A test/unittest/funcs/strjoin/tst.strjoin-nested.d
    A test/unittest/funcs/strjoin/tst.strjoin-nested.r
    A test/unittest/funcs/strjoin/tst.strjoin.d
    A test/unittest/funcs/strjoin/tst.strjoin.r
    R test/unittest/funcs/tst.strjoin.d
    R test/unittest/funcs/tst.strjoin.r

  Log Message:
  -----------
  Add support for strjoin() subroutine

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: accc7083dbe21b8b6ce7472e6dd90e76442fb2e5
      https://github.com/oracle/dtrace-utils/commit/accc7083dbe21b8b6ce7472e6dd90e76442fb2e5
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M bpf/Build
    A bpf/substr.S
    M libdtrace/dt_bpf.c
    M libdtrace/dt_cg.c
    M libdtrace/dt_dlibs.c
    R test/unittest/dif/substr2arg.d
    R test/unittest/dif/substr3arg.d
    A test/unittest/funcs/substr/err.D_PROTO_ARG.substr_non_scalar_arg2.d
    A test/unittest/funcs/substr/err.D_PROTO_ARG.substr_non_scalar_arg2.r
    A test/unittest/funcs/substr/err.D_PROTO_ARG.substr_non_scalar_arg3.d
    A test/unittest/funcs/substr/err.D_PROTO_ARG.substr_non_scalar_arg3.r
    A test/unittest/funcs/substr/err.D_PROTO_ARG.substr_non_string_arg1.d
    A test/unittest/funcs/substr/err.D_PROTO_ARG.substr_non_string_arg1.r
    A test/unittest/funcs/substr/err.D_PROTO_LEN.substr_missing_arg.d
    A test/unittest/funcs/substr/err.D_PROTO_LEN.substr_missing_arg.r
    A test/unittest/funcs/substr/err.D_PROTO_LEN.substr_too_few_args.d
    A test/unittest/funcs/substr/err.D_PROTO_LEN.substr_too_few_args.r
    A test/unittest/funcs/substr/err.D_PROTO_LEN.substr_too_many_args.d
    A test/unittest/funcs/substr/err.D_PROTO_LEN.substr_too_many_args.r
    A test/unittest/funcs/substr/err.substr_null_arg1.d
    A test/unittest/funcs/substr/err.substr_null_arg1.r
    A test/unittest/funcs/substr/substr2arg.d
    A test/unittest/funcs/substr/substr2arg.r
    A test/unittest/funcs/substr/substr3arg.d
    A test/unittest/funcs/substr/substr3arg.r
    A test/unittest/funcs/substr/tst.substr-large-idx.d
    A test/unittest/funcs/substr/tst.substr-large-idx.r
    A test/unittest/funcs/substr/tst.substr-multi-const-cnt-neg.d
    A test/unittest/funcs/substr/tst.substr-multi-const-cnt-neg.r
    A test/unittest/funcs/substr/tst.substr-multi-const-cnt-pos.d
    A test/unittest/funcs/substr/tst.substr-multi-const-cnt-pos.r
    A test/unittest/funcs/substr/tst.substr-multi-const-idx-neg.d
    A test/unittest/funcs/substr/tst.substr-multi-const-idx-neg.r
    A test/unittest/funcs/substr/tst.substr-multi-const-idx-pos.d
    A test/unittest/funcs/substr/tst.substr-multi-const-idx-pos.r
    A test/unittest/funcs/substr/tst.substr-multi-var-cnt-neg.d
    A test/unittest/funcs/substr/tst.substr-multi-var-cnt-neg.r
    A test/unittest/funcs/substr/tst.substr-multi-var-cnt-pos.d
    A test/unittest/funcs/substr/tst.substr-multi-var-cnt-pos.r
    A test/unittest/funcs/substr/tst.substr-multi-var-idx-neg.d
    A test/unittest/funcs/substr/tst.substr-multi-var-idx-neg.r
    A test/unittest/funcs/substr/tst.substr-multi-var-idx-pos.d
    A test/unittest/funcs/substr/tst.substr-multi-var-idx-pos.r
    A test/unittest/funcs/substr/tst.substr-strjoin.d
    A test/unittest/funcs/substr/tst.substr-strjoin.r
    A test/unittest/funcs/substr/tst.substr.d
    A test/unittest/funcs/substr/tst.substr.r
    A test/unittest/funcs/substr/tst.substrminate.d
    A test/unittest/funcs/substr/tst.substrminate.r
    R test/unittest/funcs/tst.substr.d
    R test/unittest/funcs/tst.substr.r
    R test/unittest/funcs/tst.substrminate.d
    R test/unittest/funcs/tst.substrminate.r

  Log Message:
  -----------
  Add support for substr() subroutine

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: a0c70c5de7cb9df770cde5b8f9c1fd275eee070f
      https://github.com/oracle/dtrace-utils/commit/a0c70c5de7cb9df770cde5b8f9c1fd275eee070f
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M NEWS
    M dtrace.spec

  Log Message:
  -----------
  Update NEWS and spec file for errata release 2.0.0-1.7

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: b496f92044f1522bf3ff25a8ebd72a5ba4200807
      https://github.com/oracle/dtrace-utils/commit/b496f92044f1522bf3ff25a8ebd72a5ba4200807
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M cmd/dtrace.c

  Log Message:
  -----------
  Add pre-release banner and adjust testsuite

Adding a banner indicating that this is a pre-release that offers
limited functionality.  Also mark all test directories as unreliable,
nd therefore all tests will be skipped for now until verifiable
functionality is available.

Orabug: 30619056
Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 32d9bb2878cac785b0818cc82bf053852629f70e
      https://github.com/oracle/dtrace-utils/commit/32d9bb2878cac785b0818cc82bf053852629f70e
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    A buildrpm/ol7/dtrace.spec
    A buildrpm/ol8/dtrace.spec
    A tag-me-for-uek

  Log Message:
  -----------
  Set up branch for OL7 and OL8 building from source tree

Orabug: 30619056
Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: c7ccee6462a2ea439e8d2fff3f8de6a3cb0fe240
      https://github.com/oracle/dtrace-utils/commit/c7ccee6462a2ea439e8d2fff3f8de6a3cb0fe240
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec

  Log Message:
  -----------
  Updating spec files to explicitly set a build kernel version

Orabug: 30619056
Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 813c724aba8adb0e4b22204a8f2315203773f6f7
      https://github.com/oracle/dtrace-utils/commit/813c724aba8adb0e4b22204a8f2315203773f6f7
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M runtest.sh

  Log Message:
  -----------
  test: ensure that the pre-release banner does not interfere with testing

The pre-release version of DTrace v2 outputs a banner message to inform
the user of the pre-release status of this tool.  Tests that verify
output were reporting failure because of the unexpected extra string
in the output.

This commit filters out the pre-release banner before any output
processing takes place.

Orabug: 30619056
Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 39a75df9f5d24ff78cb65167b0d928a0a20d5d18
      https://github.com/oracle/dtrace-utils/commit/39a75df9f5d24ff78cb65167b0d928a0a20d5d18
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec

  Log Message:
  -----------
  Update spec files for newest source code sync

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 27217e1c02235c5005ac1327b6534bbcd700c18f
      https://github.com/oracle/dtrace-utils/commit/27217e1c02235c5005ac1327b6534bbcd700c18f
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec

  Log Message:
  -----------
  Update spec files for ol7 and ol8

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 3cf4fabd263bf9a98c596a1acdd5235bc07b1c93
      https://github.com/oracle/dtrace-utils/commit/3cf4fabd263bf9a98c596a1acdd5235bc07b1c93
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M cmd/dtrace.c
    M runtest.sh

  Log Message:
  -----------
  Add pre-release banner UNLESS in test suite

A previous commit added a pre-release banner.  The commit message
said testing was decommissioned, but that was not the case; there
were simply widespread failures.  A later commit instituted some
mechanisms to filter out the banner, but they did not cover every
case, resulting in at least one known test FAIL.

Suppress the banner when the test suite is being run.  Remove the
filtering mechanisms.

Orabug: 31694125
Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Nick Alcock <nick.alcock at oracle.com>


  Commit: b227858b632fd0d81d3322a7331d69d818a9462d
      https://github.com/oracle/dtrace-utils/commit/b227858b632fd0d81d3322a7331d69d818a9462d
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    A test/tags.default

  Log Message:
  -----------
  Skip unstable tests for release testing

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: 87bffd09cbcffc7b635bfa2752d8c7e7c02eb8fa
      https://github.com/oracle/dtrace-utils/commit/87bffd09cbcffc7b635bfa2752d8c7e7c02eb8fa
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec

  Log Message:
  -----------
  Update spec files for ol7 and ol8

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>


  Commit: a193cd0181b06cd0d2a9fac2b141c0465a9aa78d
      https://github.com/oracle/dtrace-utils/commit/a193cd0181b06cd0d2a9fac2b141c0465a9aa78d
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec

  Log Message:
  -----------
  Update spec files for ol7 and ol8

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: a656bdbb1bc9a9232db8bba980ea0f4dd7f97336
      https://github.com/oracle/dtrace-utils/commit/a656bdbb1bc9a9232db8bba980ea0f4dd7f97336
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec

  Log Message:
  -----------
  Update spec files for ol7 and ol8

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: c5ffb3f9ab20673ac0bbef317605eef29a04d0e2
      https://github.com/oracle/dtrace-utils/commit/c5ffb3f9ab20673ac0bbef317605eef29a04d0e2
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec

  Log Message:
  -----------
  Update spec files for ol7 and ol8

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 546b28d1a7eae4e1189a326cc04c60b93cc997a0
      https://github.com/oracle/dtrace-utils/commit/546b28d1a7eae4e1189a326cc04c60b93cc997a0
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec

  Log Message:
  -----------
  Update spec files for ol7 and ol8

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: fce58d1515f709c553011a1324bcb6847fa94d5b
      https://github.com/oracle/dtrace-utils/commit/fce58d1515f709c553011a1324bcb6847fa94d5b
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec
    M dtrace.spec

  Log Message:
  -----------
  Update spec fles for ol7 and ol8

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: ff1db12a877c563fd287b73d629064bfa639f1c3
      https://github.com/oracle/dtrace-utils/commit/ff1db12a877c563fd287b73d629064bfa639f1c3
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec

  Log Message:
  -----------
  Update spec fles for ol7 and ol8

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 8a7347fb4a5273e3a4d8981049824529c2e7f915
      https://github.com/oracle/dtrace-utils/commit/8a7347fb4a5273e3a4d8981049824529c2e7f915
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M test/unittest/funcs/err.inet_ntoabadaddr.d
    M test/unittest/funcs/err.inet_ntopbadaddr.d
    M test/unittest/funcs/err.inet_ntopbadarg.d
    M test/unittest/offsetof/err.D_UNKNOWN.OffsetofNULL.r
    M test/unittest/types/err.D_UNKNOWN.dupenum.r
    M test/unittest/types/err.D_UNKNOWN.dupstruct.r
    M test/unittest/union/err.D_DECL_INCOMPLETE.circular.r
    M test/unittest/union/err.D_DECL_INCOMPLETE.order.r
    M test/unittest/union/err.D_DECL_INCOMPLETE.simple.r

  Log Message:
  -----------
  Fix up test cases affected by libctf vs libdtrace-ctf incompatibilities

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: f53b299444584a10f3bfafabd2ea6249daf8bb58
      https://github.com/oracle/dtrace-utils/commit/f53b299444584a10f3bfafabd2ea6249daf8bb58
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M buildrpm/ol7/dtrace.spec
    M buildrpm/ol8/dtrace.spec

  Log Message:
  -----------
  Add bugdb numbers

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 6ecea92144c8cecfb5c0a5f5f6cb40285f15e82e
      https://github.com/oracle/dtrace-utils/commit/6ecea92144c8cecfb5c0a5f5f6cb40285f15e82e
  Author: Kris Van Hees <kris.van.hees at oracle.com>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M test/unittest/enum/err.D_UNKNOWN.RepeatIdentifiers.r

  Log Message:
  -----------
  Fix another test in view of libctf differences

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>


Compare: https://github.com/oracle/dtrace-utils/compare/564c81bcc91e%5E...6ecea92144c8



More information about the DTrace-devel mailing list