[DTrace-devel] [PATCH REVIEW 5/6] tests: fix usdt/tst.dlclose1.sh

Eugene Loh eugene.loh at oracle.com
Thu Sep 9 11:53:34 PDT 2021


Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

On 9/9/21 7:13 AM, Nick Alcock wrote:
> This test fails purely because of a bufsize expansion message, since in
> v2 the bufsize must be at least one page.
>
> Boost the bufsize in the test to the largest likely page size (64KiB,
> seen on AArch64) to quash the message.
>
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>   test/unittest/usdt/tst.dlclose1.sh | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/test/unittest/usdt/tst.dlclose1.sh b/test/unittest/usdt/tst.dlclose1.sh
> index 017bff43c6f0..ee913f6b4bd9 100755
> --- a/test/unittest/usdt/tst.dlclose1.sh
> +++ b/test/unittest/usdt/tst.dlclose1.sh
> @@ -7,8 +7,6 @@
>   #
>   # This test verifies that USDT providers are removed when its associated
>   # load object is closed via dlclose(3dl).
> -#
> -# @@xfail: dtv2
>   
>   PATH=/usr/bin:/usr/sbin:$PATH
>   
> @@ -115,7 +113,7 @@ if [ $? -ne 0 ]; then
>   fi
>   
>   script() {
> -	$dtrace -Zw -x bufsize=1k -c ./main -qs /dev/stdin <<EOF
> +	$dtrace -Zw -x bufsize=64k -c ./main -qs /dev/stdin <<EOF
>   	syscall::pause:entry,
>   	syscall::rt_sig*:entry
>   	/pid == \$target/



More information about the DTrace-devel mailing list