[DTrace-devel] [PATCH REVIEW 3/4] fix a tiny comment niggle

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

On 9/9/21 7:13 AM, Nick Alcock wrote:
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> ---
>   libdtrace/dt_open.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> This is just a stylistic nit I spotted while doing the specs work.
>
> diff --git a/libdtrace/dt_open.c b/libdtrace/dt_open.c
> index 5908920d9042..867a61a30cc5 100644
> --- a/libdtrace/dt_open.c
> +++ b/libdtrace/dt_open.c
> @@ -781,7 +781,8 @@ dt_vopen(int version, int flags, int *errp,
>   	for (i = 0; i < DTRACEOPT_MAX; i++)
>   		dtp->dt_options[i] = DTRACEOPT_UNSET;
>   
> -	/* FIXME: the default value of strsize must be set.
> +	/*
> +	 * FIXME: the default value of strsize must be set.
>   	 * In legacy DTrace, the value was read from the kernel
>   	 * in dt_options_load().  When string handling is done,
>   	 * we will introduce a real solution suitable for this