[DTrace-devel] [PATCH v2 06/11] kernpath: delete the dt_kernpath 'public API wrappers'

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

On 10/20/21 2:53 PM, Nick Alcock wrote:
> These were used by the old module dumper to as an escape hatch to get
> inside libdtrace and use its facilities to locate kernel modules.

s/to as an/as an/

> Now the old module dumper is dead, we don't need this any more.
>
> Signed-off-by: Nick Alcock<nick.alcock at oracle.com>
> ---
>   libdtrace/dt_kernel_module.c | 19 -------------------
>   libdtrace/dt_kernel_module.h | 20 --------------------
>   libdtrace/libdtrace.ver      |  7 -------
>   3 files changed, 46 deletions(-)
>
> diff --git a/libdtrace/dt_kernel_module.c b/libdtrace/dt_kernel_module.c
> index e8267ace83f3..47a4cc04e0bf 100644
> --- a/libdtrace/dt_kernel_module.c
> +++ b/libdtrace/dt_kernel_module.c
> @@ -212,22 +212,3 @@ dt_kern_path_lookup_by_name(dtrace_hdl_t *dtp, const char *name)
>   
>   	return NULL;
>   }
> -
> -/*
> - * Public API wrappers.
> - */
> -dt_kern_path_t *
> -dtrace__internal_kern_path_create(dtrace_hdl_t *dtp, char *name, char *path)
> -    __attribute__((alias("dt_kern_path_create")));
> -
> -void
> -dtrace__internal_kern_path_destroy(dtrace_hdl_t *dtp, dt_kern_path_t *dkpp)
> -    __attribute__((alias("dt_kern_path_destroy")));
> -
> -int
> -dtrace__internal_kern_path_update(dtrace_hdl_t *dtp)
> -    __attribute__((alias("dt_kern_path_update")));
> -
> -dt_kern_path_t *
> -dtrace__internal_kern_path_lookup_by_name(dtrace_hdl_t *dtp, const char *name)
> -    __attribute__((alias("dt_kern_path_lookup_by_name")));
> diff --git a/libdtrace/dt_kernel_module.h b/libdtrace/dt_kernel_module.h
> index 40bc33d00a08..3397106a708a 100644
> --- a/libdtrace/dt_kernel_module.h
> +++ b/libdtrace/dt_kernel_module.h
> @@ -17,24 +17,4 @@ extern dt_kern_path_t *dt_kern_path_lookup_by_name(dtrace_hdl_t *dtp,
>       const char *name);
>   extern void dt_kern_path_destroy(dtrace_hdl_t *dtp, dt_kern_path_t *dkpp);
>   
> -/*
> - * Public API wrappers.
> - *
> - * Programs outside libdtrace can call these -- but their API stability
> - * is not guaranteed, and they should only be called by programs inside
> - * the DTrace package.
> - */
> -
> -extern dt_kern_path_t *
> -dtrace__internal_kern_path_create(dtrace_hdl_t *dtp, char *name, char *path);
> -
> -extern void
> -dtrace__internal_kern_path_destroy(dtrace_hdl_t *dtp, dt_kern_path_t *dkpp);
> -
> -extern int
> -dtrace__internal_kern_path_update(dtrace_hdl_t *dtp);
> -
> -extern dt_kern_path_t *
> -dtrace__internal_kern_path_lookup_by_name(dtrace_hdl_t *dtp, const char *name);
> -
>   #endif	/* _DT_KERNEL_MODULE_H */
> diff --git a/libdtrace/libdtrace.ver b/libdtrace/libdtrace.ver
> index ad3b43233321..89df28c56f57 100644
> --- a/libdtrace/libdtrace.ver
> +++ b/libdtrace/libdtrace.ver
> @@ -94,10 +94,3 @@ LIBDTRACE_1.0 {
>       local:
>   	*;
>   };
> -
> -# These are exposed for internal purposes, and are not part of the public
> -# interface.
> -LIBDTRACE_PRIVATE
> -{
> -	dtrace__internal_*;
> -};
> -- 2.33.1.257.g9e0974a4e8 
> _______________________________________________ DTrace-devel mailing 
> list DTrace-devel at oss.oracle.com 
> https://oss.oracle.com/mailman/listinfo/dtrace-devel