[DTrace-devel] [PATCH 2/4] Skip tests that trigger a compilation failure due to ctd-api.h

[Kris Van Hees]

On Mon, Nov 01, 2021 at 05:46:04PM -0400, Eugene Loh wrote:
> On 11/1/21 4:13 PM, Kris Van Hees wrote:
> 
> > On Mon, Nov 01, 2021 at 07:57:53PM +0000, Nick Alcock wrote:
> >> On 30 Oct 2021, Kris Van Hees spake thusly:
> >>
> >>> diff --git a/test/unittest/consumer/addr2str-null.c b/test/unittest/consumer/addr2str-null.c
> >>> index 62a30da2..c6d739d6 100644
> >>> --- a/test/unittest/consumer/addr2str-null.c
> >>> +++ b/test/unittest/consumer/addr2str-null.c
> >>> @@ -4,6 +4,7 @@
> >>>    * Licensed under the Universal Permissive License v 1.0 as shown at
> >>>    * http://oss.oracle.com/licenses/upl.
> >>>    */
> >>> +/* @@skip: needs work */
> >> Wouldn't it be better to do the work? I can look at it if you like. It's
> >> probably not too tricky.
> > Absolutely.
> Great.
> 
> One way to look at the problem is that the fix of  c80033dcc000 "Fix 
> compilation problems in C tests" does not work for --use-installed.

The problem is primarily that ctf-api.h cannot be found because it is a
headwr file that resides in the source tree and is not installed as part
of the headers in the RPM.  It exists to deal with libctf and libdtrace-ctf
both being valid options for CTF for DTrace, and they have differently named
API header files.

At least, that is what it looks like.