[DTrace-devel] [PATCH 01/16] Remove fasttrap references and introduce pid-provider variants

[Eugene Loh]

On 3/19/21 7:11 PM, Eugene Loh wrote:

> Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
> with some minor comments below.
>
> On 3/19/21 12:54 AM, Kris Van Hees wrote:
>> Since the fasttrap provider is no longer necessary, the following
>> two datatypes are being renamed:
>>
>>     fasttrap_probe_type_t -> pid_probe_type_t
>>     fasttrap_probe_spec_t -> pid_probe_spec_t
>
> The pid_*_t names have extraneous underscores;  should be 
> pid_probetype_t and pid_probespec_t.

Incidentally, I'm unclear what namespace rules we're using.  So, I'll 
ask.  Should those pid_probe*_t names have dt_ prefixes?