[DTrace-devel] [PATCH 08/16] Add support for ENOTSUPP error code

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
but...

On 3/19/21 12:54 AM, Kris Van Hees wrote:
> The ENOTSUPP error code is not meant to be exposed by the kernel, and
> it is in fact specific to NFSv3.  However, the uprobes implementation
> in the kernel uses it to indicate that a uprobe could not be placed at
> the requested location.  This causes it to be exposed to us through
> the perf_event_open() system call.
>
> When it is encountered, the "Operation not supported" message will be
> reported.
>
> diff --git a/libdtrace/dt_error.c b/libdtrace/dt_error.c
> +	} else if (error == 524) {
> +		/*
> +		 * This is an error code that is supposedly specific to NFSv3.

While the commit message explicitly refers to ENOTSUPP, it would also be 
nice if the source code did as well.  E.g.,
"524"
could become
"524 /* ENOTSUPP */"
or else
"This is"
could become
"ENOTSUPP is".