[DTrace-devel] [PATCH 4/4] Move raise() tests to unittest/actions/raise with updates

Eugene Loh eugene.loh at oracle.com
Wed Jun 9 21:35:53 PDT 2021


Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

On 6/8/21 11:37 PM, Kris Van Hees wrote:
> Tests have been updated to not depend on trace() with a string argument.

I just don't get it.  There is no point.  What could happen?  A test 
fails for a reason we did not anticipate?  That would be good -- a 
godsend, actually -- not bad.  These movements to narrow our test 
coverage do not move us closer to a quality tool.

Anyhow, to the extent that the commit message is going describe the 
patch (beyond the move referenced in the subject line), we should also 
mention that the test time out return code is being changed to 124.




More information about the DTrace-devel mailing list