[DTrace-devel] [PATCH 3/4] Mark dynamic data trace() test as PASS

Eugene Loh eugene.loh at oracle.com
Wed Jun 9 18:58:15 PDT 2021


Reviewed-by: Eugene Loh <eugene.loh at oracle.com>

On 6/8/21 11:37 PM, Kris Van Hees wrote:
> This test was failing because of a wrong line number in the expected
> output.
>
> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> ---
>   test/unittest/actions/trace/err.D_TRACE_DYN.d | 4 ++--
>   test/unittest/actions/trace/err.D_TRACE_DYN.r | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/unittest/actions/trace/err.D_TRACE_DYN.d b/test/unittest/actions/trace/err.D_TRACE_DYN.d
> index 47cc3570..6d933fd7 100644
> --- a/test/unittest/actions/trace/err.D_TRACE_DYN.d
> +++ b/test/unittest/actions/trace/err.D_TRACE_DYN.d
> @@ -1,10 +1,10 @@
>   /*
>    * Oracle Linux DTrace.
> - * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved.
>    * Licensed under the Universal Permissive License v 1.0 as shown at
>    * http://oss.oracle.com/licenses/upl.
>    */
> -/* @@xfail: dtv2 */
> +
>   /*
>    * ASSERTION: The trace() action does not accept a dynamic expression as value.
>    *
> diff --git a/test/unittest/actions/trace/err.D_TRACE_DYN.r b/test/unittest/actions/trace/err.D_TRACE_DYN.r
> index b655c9b9..ba1b8852 100644
> --- a/test/unittest/actions/trace/err.D_TRACE_DYN.r
> +++ b/test/unittest/actions/trace/err.D_TRACE_DYN.r
> @@ -1,2 +1,2 @@
>   -- @@stderr --
> -dtrace: failed to compile script test/unittest/actions/trace/err.D_TRACE_DYN.d: [D_TRACE_DYN] line 20: trace( ) may not be applied to a dynamic expression
> +dtrace: failed to compile script test/unittest/actions/trace/err.D_TRACE_DYN.d: [D_TRACE_DYN] line 19: trace( ) may not be applied to a dynamic expression



More information about the DTrace-devel mailing list