[DTrace-devel] [PATCH 03/12] Check that stackdepth is nonzero in test

[Eugene Loh]

On 6/3/21 5:40 PM, Kris Van Hees wrote:

> On Thu, Jun 03, 2021 at 03:58:58PM -0400, Eugene Loh wrote:
>> There could be an empty stack(), but not in the case of this test.
> Well, that is not correct because in this patch the probe is still BEGIN, and
> with your stack implementation from a patch further in the series, the stack
> for the BEGIN probe *is* empty.  So, with the test in this patch, you are
> actually causing a failure even with the stack implementation added in.
>
> So, at a minimum you then should change the probe that this test uses, and
> document why you use a particular probe.
Oops.  Yeah, good point.  Okay, v2 of the patch coming right up. Note 
that the commit subject line has also undergone a change to reflect the 
update.