[DTrace-devel] [PATCH 15/20] Add support for string constants in compiled D programs

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
but I think test/unittest/types/tst.stringconstants.d needs to lose its 
XFAIL (and therefore needs an updated copyright year). Also, ...

On 6/2/21 1:48 AM, Kris Van Hees wrote:
> diff --git a/include/dtrace/dif_defines.h b/include/dtrace/dif_defines.h
> -#define	DIF_STROFF_MAX		0xffff	/* highest string table offset */
> +#define	DIF_STROFF_MAX		0x7fff	/* highest string table offset */

I'm guessing (not confidently) why this change was made.  Instead of me 
embarrassing myself, would you tell me?  :^)
Also, file needs updated copyright year.

> diff --git a/test/unittest/scalars/tst.self.d b/test/unittest/scalars/tst.self.d

Okay, but need updated copyright year.  Also, while the file is being 
touched anyhow, how about
     Declare self a variable and assign appropriate value.
     ->
     Declare a self variable and assign appropriate value.
assuming that makes more sense.

> diff --git a/test/unittest/sizeof/tst.SizeofString2.d b/test/unittest/sizeof/tst.SizeofString2.d

Okay, but need updated copyright year.