[DTrace-devel] [PATCH 19/20] Implement a framework for D subroutines incl. strlen() implementation

[Kris Van Hees]

On Wed, Jun 02, 2021 at 12:56:05PM -0400, Eugene Loh wrote:
> A quick comment on this one.  The framework looks nice, but it seems to 
> me that the patch induces widespread test failures. Tests will use 
> subroutines, we call dt_cg_call_subr(), fun will generally be NULL, we 
> call a NULL function, and we dump core.  A partially implemented 
> framework needs guardrails for not-yet-implemented subroutines.

Yes, that is getting added in.  This is the one patch that I probably should
have marked WIP because it is part of other work that I still needed to get
t>o be corrected.

Thanks for catching that - it got late last night and I thought I marked the
appropriate patches WIP so I would hold them back but this one slipped through.

Anyway, other than that detail, i.e. the handling of non-existant subroutines,
the implementation should be as desired.  With more of a framework for
subroutines it is likely that we will see more tests that need to be marked
XFAIL.  I'm looking into that.

> On 6/2/21 1:48 AM, Kris Van Hees wrote:
> > This patch provides the skeleton for the implementation of subroutines
> > in D.  The strlen() subroutine is provided as a first example of how
> > to imeplement subroutines.  It is equivalent to the implementation of
> > D actions in the code generator.
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel