[DTrace-devel] [PATCH 2/2] Rename tests where same name is used for .d and .sh test

[Kris Van Hees]

On Fri, Jul 02, 2021 at 07:10:49PM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> When two tests have the same base name but .d and .sh extensions,
> the .d test is silently ignored and the .sh test is run in its
> place.  Rename either test to avoid such a conflict.
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> ---
>  test/unittest/scripting/{tst.sid.d => tst.sid0.d}      | 0
>  test/unittest/variables/bvar/{tst.id.sh => tst.id1.sh} | 0

I really do not like this renaming.  The addition of 0 and 1 respectively is
not doing anything other than arbitrarily differentiate between the tests.
A more descriptive name might be useful since you are doing a rename anyway.
E.g. tst.id.d remains but make tst.id.sh to be tst.id-valid.sh.  And same with
tst.sid.d remaining but tst.sid.sh becomes tst.sid-valid.sh.

>  2 files changed, 0 insertions(+), 0 deletions(-)
>  rename test/unittest/scripting/{tst.sid.d => tst.sid0.d} (100%)
>  rename test/unittest/variables/bvar/{tst.id.sh => tst.id1.sh} (100%)
> 
> diff --git a/test/unittest/scripting/tst.sid.d b/test/unittest/scripting/tst.sid0.d
> similarity index 100%
> rename from test/unittest/scripting/tst.sid.d
> rename to test/unittest/scripting/tst.sid0.d
> diff --git a/test/unittest/variables/bvar/tst.id.sh b/test/unittest/variables/bvar/tst.id1.sh
> similarity index 100%
> rename from test/unittest/variables/bvar/tst.id.sh
> rename to test/unittest/variables/bvar/tst.id1.sh
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel