[DTrace-devel] [PATCH v2] Implement normalize() and denormalize()

Kris Van Hees kris.van.hees at oracle.com
Fri Jan 15 21:41:54 PST 2021


On Fri, Jan 15, 2021 at 09:15:02PM -0800, Eugene Loh wrote:
> Okay, but two questions:
> 
> *)  In the new (renormalization) test, the Copyright is 2006,2021. Is 
> the 2006 intentional (because the test is based on normalize.d) or a 
> copy-and-paste error?

It was intentional, but in retrospect probably better to just go with 2021.

> *)  You mentioned you would change the normalize() prototype so that the 
> second argument would be required (which it is!).  Was that change 
> intended for this patch or for a later patch?  It should be added to the 
> current patch since, as things stand, 
> test/unittest/aggs/err.D_PROTO_LEN.norm_too_few_args.d now fails.

Woops, forgot to add dt_open.c I guess.  Having a bad day with these things :(



More information about the DTrace-devel mailing list