[DTrace-devel] [oracle/dtrace-utils] 0f94bd: dtrace: add sample scripts for building dev DTrace...

euloh noreply at github.com
Tue Jan 12 11:31:26 PST 2021 

  Branch: refs/heads/dev
  Home:   https://github.com/oracle/dtrace-utils
  Commit: 0f94bd89e2dd645a1aae9a22b2498b8649e5afb2
      https://github.com/oracle/dtrace-utils/commit/0f94bd89e2dd645a1aae9a22b2498b8649e5afb2
  Author: David  Mc Lean <david.mclean at oracle.com>
  Date:   2020-12-18 (Fri, 18 Dec 2020)

  Changed paths:
    A dists/Ubuntu/README
    A dists/Ubuntu/build_dtrace.sh
    A dists/Ubuntu/kernel/steps/0_upgrade.sh
    A dists/Ubuntu/kernel/steps/1_deps_clone.sh
    A dists/Ubuntu/kernel/steps/2_build_bpf.sh
    A dists/Ubuntu/kernel/steps/3_kernel_branch.sh
    A dists/Ubuntu/kernel/steps/4_prep_kernel.sh
    A dists/Ubuntu/kernel/steps/5_build_kernel.sh
    A dists/Ubuntu/kernel/steps/6_boot_kernel.sh
    A dists/Ubuntu/kernel/steps/eg_dtrace_kern
    A dists/Ubuntu/kernel/steps/eg_ubuntu_kern
    A dists/Ubuntu/prepare_kernel.sh

  Log Message:
  -----------
  dtrace: add sample scripts for building dev DTrace on Ubuntu

Signed-off-by: David Mc Lean <david.mclean at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


  Commit: 4439e6bea4a72b91a80b3dd18fe2dd914d02083b
      https://github.com/oracle/dtrace-utils/commit/4439e6bea4a72b91a80b3dd18fe2dd914d02083b
  Author: Eugene Loh <eugene.loh at oracle.com>
  Date:   2021-01-12 (Tue, 12 Jan 2021)

  Changed paths:
    A CODING-STYLE
    M bpf/get_bvar.c
    M cmd/ctf_module_dump.c
    M cmd/dtrace.c
    M include/dtrace/actions_defines.h
    M include/dtrace/dif.h
    M include/dtrace/dif_defines.h
    M include/dtrace/metadesc.h
    M include/sys/bitmap.h
    M libdtrace/dt_as.c
    M libdtrace/dt_buf.c
    M libdtrace/dt_cc.c
    M libdtrace/dt_cg.c
    M libdtrace/dt_consume.c
    M libdtrace/dt_decl.c
    M libdtrace/dt_dis.c
    M libdtrace/dt_dlibs.c
    M libdtrace/dt_dof.c
    M libdtrace/dt_error.c
    M libdtrace/dt_grammar.y
    M libdtrace/dt_handle.c
    M libdtrace/dt_ident.c
    M libdtrace/dt_kernel_module.c
    M libdtrace/dt_lex.l
    M libdtrace/dt_link.c
    M libdtrace/dt_module.c
    M libdtrace/dt_open.c
    M libdtrace/dt_options.c
    M libdtrace/dt_parser.c
    M libdtrace/dt_pcap.c
    M libdtrace/dt_pcb.c
    M libdtrace/dt_pid.c
    M libdtrace/dt_pragma.c
    M libdtrace/dt_printf.c
    M libdtrace/dt_probe.c
    M libdtrace/dt_proc.c
    M libdtrace/dt_program.c
    M libdtrace/dt_provider.c
    M libdtrace/dt_regset.c
    M libdtrace/dt_string.c
    M libdtrace/dt_strtab.c
    M libdtrace/dt_subr.c
    M libdtrace/dt_symbol_modops.h
    M libdtrace/dt_symtab.c
    M libdtrace/dt_work.c
    M libdtrace/dt_xlator.c
    M libdtrace/ip.d
    M libdtrace/mkerrtags.sh
    M libdtrace/mknames.sh
    M libport/gmatch.c
    M libport/p_online.c
    M libport/strlcat.c
    M libport/strlcpy.c
    M libproc/Pcontrol.c
    M libproc/Pcontrol.h
    M libproc/Psymtab.c
    M libproc/arm64/isadep.c
    M libproc/arm64/isadep.h
    M libproc/elfish.c
    M libproc/elfish_64.c
    M libproc/i386/isadep.c
    M libproc/i386/isadep.h
    M libproc/isadep_dispatch.c
    M libproc/libproc.h
    M libproc/mkoffsets.sh
    M libproc/rtld_db.c
    M libproc/sparc/isadep.c
    M test/demo/struct/kstat.d
    M test/stress/misc/tst.roch.d
    M test/triggers/bogus-ioctl.c
    M test/triggers/libproc-consistency.c
    M test/triggers/libproc-execing-bkpts-victim.c
    M test/triggers/libproc-execing-bkpts.c
    M test/triggers/libproc-lookup-by-name.c
    M test/triggers/libproc-lookup-victim.c
    M test/triggers/libproc-pldd.c
    M test/triggers/pid-tst-args1.c
    M test/triggers/pid-tst-float.c
    M test/triggers/pid-tst-fork.c
    M test/triggers/pid-tst-gcc.c
    M test/triggers/pid-tst-ret1.c
    M test/triggers/pid-tst-ret2.c
    M test/triggers/pid-tst-vfork.c
    M test/triggers/pid-tst-weak1.c
    M test/triggers/pid-tst-weak2.c
    M test/triggers/proc-tst-sigwait.c
    M test/triggers/profile-tst-ufuncsort.c
    M test/triggers/raise-tst-raise1.c
    M test/triggers/raise-tst-raise2.c
    M test/triggers/raise-tst-raise3.c
    M test/triggers/syscall-tst-args.c
    M test/triggers/usdt-tst-argmap.c
    M test/triggers/usdt-tst-args.c
    M test/triggers/usdt-tst-forker.c
    M test/triggers/ustack-tst-bigstack.c
    M test/triggers/ustack-tst-mtspin.c
    M test/triggers/ustack-tst-spin.c
    M test/unittest/aggs/err.D_LQUANT_MISMATCH.lqbadarg2.d
    M test/unittest/aggs/tst.aggmod_full2.sh
    M test/unittest/aggs/tst.lquantize.d
    M test/unittest/aggs/tst.subr.d
    M test/unittest/arithmetic/tst.basics.d
    M test/unittest/bitfields/err.D_SIZEOF_BITFIELD.SizeofBitfield.d
    M test/unittest/bitfields/tst.SizeofBitField.d
    M test/unittest/bitfields/tst.SizeofBitField.r
    M test/unittest/builtinvar/tst.psinfo-bug21984854.d
    M test/unittest/consumer/addr2str-null.c
    M test/unittest/consumer/tst.merge_ranges_bug25767469.c
    M test/unittest/consumer/tst.symbols.c
    M test/unittest/error/tst.DTRACEFLT_BADADDR2.d
    M test/unittest/error/tst.DTRACEFLT_UNKNOWN.d
    M test/unittest/funcs/err.badalloca.d
    M test/unittest/funcs/err.badbcopy.d
    M test/unittest/funcs/err.badbcopy1.d
    M test/unittest/funcs/err.badbcopy2.d
    M test/unittest/funcs/err.badbcopy3.d
    M test/unittest/funcs/err.badbcopy4.d
    M test/unittest/funcs/err.badbcopy5.d
    M test/unittest/funcs/err.copyoutbadaddr.sh
    M test/unittest/funcs/err.copyoutstrbadaddr.sh
    M test/unittest/funcs/err.inet_ntopbadarg.d
    M test/unittest/funcs/err.link_ntopbadarg.d
    M test/unittest/funcs/tst.bcopy.d
    M test/unittest/funcs/tst.copyin.d
    M test/unittest/funcs/tst.copyinto.d
    M test/unittest/funcs/tst.ddi_pathname.d
    M test/unittest/funcs/tst.inet_ntoa.d
    M test/unittest/funcs/tst.inet_ntoa6.d
    M test/unittest/funcs/tst.inet_ntop.d
    M test/unittest/funcs/tst.link_ntop.d
    M test/unittest/misc/tst.haslam.d
    M test/unittest/pid/tst.provregex1.sh
    M test/unittest/pid/tst.provregex2.sh
    M test/unittest/pid/tst.provregex4.sh
    M test/unittest/pointers/err.BadAlign.d
    M test/unittest/pointers/err.D_OP_INCOMPAT.VoidPointerArith.d
    M test/unittest/pointers/err.D_OP_LVAL.AddressChange.d
    M test/unittest/pointers/err.InvalidAddress1.d
    M test/unittest/pointers/err.InvalidAddress2.d
    M test/unittest/pointers/err.InvalidAddress3.d
    M test/unittest/pointers/err.InvalidAddress4.d
    M test/unittest/pointers/err.InvalidAddress5.d
    M test/unittest/pointers/tst.ArrayPointer1.d
    M test/unittest/pointers/tst.GlobalVar.d
    M test/unittest/pointers/tst.IntegerArithmetic1.d
    M test/unittest/pointers/tst.PointerArithmetic1.d
    M test/unittest/pointers/tst.PointerArithmetic3.d
    M test/unittest/pointers/tst.ValidPointer1.d
    M test/unittest/pointers/tst.ValidPointer2.d
    M test/unittest/pointers/tst.VoidCast.d
    M test/unittest/pointers/tst.basic1.d
    M test/unittest/pointers/tst.basic2.d
    M test/unittest/sizeof/err.D_IDENT_BADREF.SizeofAssoc.d
    M test/unittest/sizeof/err.D_IDENT_UNDEF.UnknownSymbol.d
    M test/unittest/sizeof/err.D_SIZEOF_TYPE.d
    M test/unittest/sizeof/err.D_SYNTAX.SizeofBadType.d
    M test/unittest/sizeof/tst.SizeofArray.d
    M test/unittest/sizeof/tst.SizeofArray.r
    M test/unittest/sizeof/tst.SizeofDataTypes.d
    M test/unittest/sizeof/tst.SizeofDataTypes.r
    M test/unittest/sizeof/tst.SizeofExpression.d
    M test/unittest/sizeof/tst.SizeofExpression.r
    M test/unittest/sizeof/tst.SizeofNULL.d
    M test/unittest/sizeof/tst.SizeofNULL.r
    M test/unittest/sizeof/tst.SizeofStrConst.d
    M test/unittest/sizeof/tst.SizeofString1.d
    M test/unittest/sizeof/tst.SizeofString1.r
    M test/unittest/sizeof/tst.SizeofString2.d
    M test/unittest/sizeof/tst.SizeofString2.r
    M test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOut.d
    M test/unittest/speculation/err.D_ACT_SPEC.SpeculateWithCopyOutStr.d
    M test/unittest/tracemem/tst.three_arg.sh
    M test/unittest/translators/err.D_DECL_TYPERED.BadTransDecl.d
    M test/unittest/translators/err.D_OP_INCOMPLETE.NonExistentInput1.d
    M test/unittest/translators/err.D_SYNTAX.BadTransDecl1.d
    M test/unittest/translators/err.D_SYNTAX.BadTransDecl3.d
    M test/unittest/translators/err.D_SYNTAX.BadTransDecl4.d
    M test/unittest/translators/err.D_TYPE_MEMBER.NonExistentInput2.d
    M test/unittest/translators/err.D_XLATE_INCOMPAT.BadInputType1.d
    M test/unittest/translators/err.D_XLATE_MEMB.NonExistentOutput2.d
    M test/unittest/translators/err.D_XLATE_NONE.BadTransDecl6.d
    M test/unittest/translators/err.D_XLATE_REDECL.RepeatTransDecl.d
    M test/unittest/translators/err.D_XLATE_SOU.NonExistentOutput1.d
    M test/unittest/translators/tst.CircularTransDecl.d
    M test/unittest/translators/tst.ForwardTag.d
    M test/unittest/translators/tst.InputAliasTrans.d
    M test/unittest/translators/tst.InputIntTrans.d
    M test/unittest/translators/tst.OutputAliasTrans.d
    M test/unittest/translators/tst.PartialDereferencing.d
    M test/unittest/translators/tst.PartialOutputTransDefn.d
    M test/unittest/translators/tst.RepeatDeclaration.d
    M test/unittest/translators/tst.SimultaneousTranslators.d
    M test/unittest/translators/tst.StructureAssignment.d
    M test/unittest/translators/tst.TransNonPointer.d
    M test/unittest/translators/tst.TransOutputPointer.d
    M test/unittest/translators/tst.TransPointer.d
    M test/unittest/translators/tst.TranslateSelf.d
    M test/unittest/translators/tst.UnionInputTrans.d
    M test/unittest/translators/tst.UnionOutputTrans.d
    M test/unittest/types/tst.basics.d
    M test/unittest/types/tst.basics.r
    M test/unittest/types/tst.complex.d
    M test/unittest/types/tst.intops.d
    M test/unittest/types/tst.inttypes.d
    M test/unittest/types/tst.inttypes.r
    M test/unittest/types/tst.ptrops.d
    M test/unittest/types/tst.struct.d
    M test/unittest/types/tst.typedef.d
    M test/unittest/usdt/tst.dlclose1.sh
    M test/unittest/usdt/tst.dlclose2.sh
    M test/unittest/usdt/tst.dlclose3.sh
    M test/unittest/usdt/tst.eliminate.sh
    M test/unittest/usdt/tst.enabled2.sh
    M test/unittest/usdt/tst.fork.sh
    M test/unittest/usdt/tst.multiple.sh
    M test/unittest/usdt/tst.onlyenabled.sh
    M test/unittest/usdt/tst.user.sh
    M test/unittest/ustack/tst.frames.sh
    M test/utils/baddof.c
    M test/utils/badioctl.c

  Log Message:
  -----------
  Refactoring for greater stylistic consistency

Make stylistic changes for greater consistency.  Where possible:
- eliminate "(void)" on function calls
- eliminate parentheses on "return" argument
- eliminate {} on single-statement "if" and "else" blocks
    (this was not done exhaustively)
- eliminate space in "sizeof ()"
- eliminate space in "(typecast) foo"
- eliminate spaces immediately inside parentheses
- consolidate to fewer lines
    (e.g., where the above changes made lines sufficiently shorter)

Update copyright notices of impacted files.

Add a document listing these and other coding-style guidelines.

Code in libbpf/ was not touched, since we expect not to retain
that code long term.

Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>


Compare: https://github.com/oracle/dtrace-utils/compare/187c56aa3f78...4439e6bea4a7

More information about the DTrace-devel mailing list