[DTrace-devel] [PATCH] Fix ERROR-in-BEGIN probe handling

Eugene Loh eugene.loh at oracle.com
Thu Aug 26 19:11:40 PDT 2021


Not the world's most thorough review, but it works for me:
     Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
The usual nit:

On 8/26/21 9:36 PM, Kris Van Hees wrote:
> The handling of ERROR probe invocations during the BEGIN probe execution
> was flawed.  It failed to continue processing BEGIN clauses once an
> ERROR invocation took place, and it didn't provide (as required) for
> processing the CPU probe data buffer twice.
>
> The continuation of processing has been corrected by ensuring that the
> correct DTrace workstatus is reported from the probe callback functions.
> The double buffer processing is now supported by passing a flag to
> st_consume_cpu() to indicate whether the tail of the ring buffer ought
> to be updated or not.

st_consume_cpu()
->
dt_consume_cpu()




More information about the DTrace-devel mailing list