[DTrace-devel] [PATCH 3/3] Verify the activity state before calling each clause

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
with the usual minor comment/question:

On 09/29/2020 04:14 PM, Kris Van Hees wrote:
> When a clause contains an exit() action, processing of all other
> clauses (even for the same probe firing) must not be executed
> anymore.  The activity state check therefore needs to not just happen
> in the trampoline, but also before every clause within the program.

Arguably, the activity check is no longer needed in the trampoline at 
all, right?  (Leaving it in is a minor implementation choice.  It saves 
the execution of a couple of instructions if probes fire at the end of a 
run.)  Maybe change the last sentence to:

"The activity state check therefore needs to happen before every clause 
within the program."