[DTrace-devel] [PATCH 2/3] Store a pointer to the activity state in the DTrace context

Eugene Loh eugene.loh at oracle.com
Wed Sep 30 08:47:09 PDT 2020


Reviewed-by: Eugene Loh <eugene.loh at oracle.com>
with very tiny comment below.

On 09/29/2020 04:14 PM, Kris Van Hees wrote:
> Rather than accessing the activity state by performing a BPF map lookup
> whenever we need it or want to modify it, we now store a pointer to the
> BPF map value in the DTrace context (dt_dctx) and access/update the
> value through that pointer.
>
>
> diff --git a/libdtrace/dt_dctx.h b/libdtrace/dt_dctx.h
> - *   LVAR_END = LVAR(n) = -256 | LVAR n         | (n = DT_VAR_LOCAL_MAX = 19)
> + *   LVAR_END = LVAR(n) = -256 | LVAR n         | (n = DT_VAR_LOCAL_MAX = 18)

Okay, though it looks like there is actually no such thing as 
DT_VAR_LOCAL_MAX.



More information about the DTrace-devel mailing list