[DTrace-devel] [PATCH] test: tst.ustackdepth-bug25949692.d timeout

[Eugene Loh]

ping for review


On 09/23/2020 10:20 PM, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
>
> The test would timeout on some systems -- e.g., an ARM VM running
> OL8.  Since it relied on syscall::ioctl:entry firing but there was
> no trigger, there was no guarantee that the test would complete in
> any particular time.
>
> Remove the test.  Its scope was very narrow (testing only that
> ustackdepth was neither 1 nor 0, in response to a particular bug)
> and focused on behavior in an implementation that is no longer used.
> Meanwhile, this built-in variable is tested more rigorously by other
> tests that, e.g., check the ustackdepth value against the actual
> depth of the ustack.
>
> Orabug: 31929511
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> ---
>   .../builtinvar/tst.ustackdepth-bug25949692.d  | 27 -------------------
>   1 file changed, 27 deletions(-)
>   delete mode 100644 test/unittest/builtinvar/tst.ustackdepth-bug25949692.d
>
> diff --git a/test/unittest/builtinvar/tst.ustackdepth-bug25949692.d b/test/unittest/builtinvar/tst.ustackdepth-bug25949692.d
> deleted file mode 100644
> index 45adddb6..00000000
> --- a/test/unittest/builtinvar/tst.ustackdepth-bug25949692.d
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -/*
> - * Oracle Linux DTrace.
> - * Copyright (c) 2017, 2020, Oracle and/or its affiliates. All rights reserved.
> - * Licensed under the Universal Permissive License v 1.0 as shown at
> - * http://oss.oracle.com/licenses/upl.
> - */
> -
> -/*
> - * ASSERTION:
> - * 	Ensure that ustackdepth is not always 1.
> - *
> - * SECTION: Variables/Built-in Variables
> - */
> -
> -#pragma D option quiet
> -
> -syscall::ioctl:entry
> -/ustackdepth == 1/
> -{
> -	exit(1);
> -}
> -
> -syscall::ioctl:entry
> -/ustackdepth > 1/
> -{
> -	exit(0);
> -}