[DTrace-devel] [PATCH] The exit() action must set the activity state to DRAINING

[Eugene Loh]

On 09/04/2020 11:45 PM, Kris Van Hees wrote:

> On Fri, Sep 04, 2020 at 09:43:07PM -0700, Eugene Loh wrote:
>> On 09/02/2020 01:56 PM, Kris Van Hees wrote:
>>> Now that activity state is supported, the exit() action needs to move
>>> the activity state to DRAINING to prevent further probe firings from
>>> being processed.
>> I don't understand this patch.  In a previous patch, we told END to
>> short circuit if the activity state is not ACTIVE.  So, if exit()
>> changes the activity state to DRAINING, then END will not execute its
>> clause.  That seems wrong.
> And yet, it is the right thing to do.  The trouble is that it won't show it
> is the right thing until some other patches go in that further modify the
> handling of BEGIN, END, exit, and the buffer consumption.
>
> Yes, this patch causes regression, but since it will not be applied without
> the upcoming companion patches (bundled as a nice patch-set) it won't matter.
> It cannot be avoided.
What's the point of posting the patch?  I thought it was being posted 
for review, but if it's incomplete then that's counterproductive.