[DTrace-devel] [PATCH] Spurious xfail due to line-number change

[Kris Van Hees]

Reviewed-by: Kris Van Hees <kris.van.hees at oracle.com>

On Mon, Aug 24, 2020 at 04:41:59PM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> These tests would also have started passing (changed from XFAIL to XPASS)
> except that the @@xfail annotation spuriously changed a line number.
> So simply eliminating the annotation causes these tests now to pass.
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> ---
>  test/unittest/probes/err.D_PDESC_ZERO.probeqtn.d      | 1 -
>  test/unittest/probes/err.D_PDESC_ZERO.tickstar.d      | 1 -
>  test/unittest/providers/err.D_PDESC_ZERO.nonprofile.d | 1 -
>  test/unittest/providers/err.D_PDESC_ZERO.wrongdec1.d  | 1 -
>  test/unittest/providers/err.D_PDESC_ZERO.wrongdec2.d  | 1 -
>  test/unittest/providers/err.D_PDESC_ZERO.wrongdec3.d  | 1 -
>  6 files changed, 6 deletions(-)
> 
> diff --git a/test/unittest/probes/err.D_PDESC_ZERO.probeqtn.d b/test/unittest/probes/err.D_PDESC_ZERO.probeqtn.d
> index 724dc032..b658cfcb 100644
> --- a/test/unittest/probes/err.D_PDESC_ZERO.probeqtn.d
> +++ b/test/unittest/probes/err.D_PDESC_ZERO.probeqtn.d
> @@ -4,7 +4,6 @@
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> -/* @@xfail: dtv2 */
>  
>  /*
>   * ASSERTION:
> diff --git a/test/unittest/probes/err.D_PDESC_ZERO.tickstar.d b/test/unittest/probes/err.D_PDESC_ZERO.tickstar.d
> index 93f00bc4..5d73a73f 100644
> --- a/test/unittest/probes/err.D_PDESC_ZERO.tickstar.d
> +++ b/test/unittest/probes/err.D_PDESC_ZERO.tickstar.d
> @@ -4,7 +4,6 @@
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> -/* @@xfail: dtv2 */
>  
>  /*
>   * ASSERTION:
> diff --git a/test/unittest/providers/err.D_PDESC_ZERO.nonprofile.d b/test/unittest/providers/err.D_PDESC_ZERO.nonprofile.d
> index d3d85ac3..20e6d6f9 100644
> --- a/test/unittest/providers/err.D_PDESC_ZERO.nonprofile.d
> +++ b/test/unittest/providers/err.D_PDESC_ZERO.nonprofile.d
> @@ -4,7 +4,6 @@
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> -/* @@xfail: dtv2 */
>  
>  /*
>   * ASSERTION:
> diff --git a/test/unittest/providers/err.D_PDESC_ZERO.wrongdec1.d b/test/unittest/providers/err.D_PDESC_ZERO.wrongdec1.d
> index f231cbee..1d795a9b 100644
> --- a/test/unittest/providers/err.D_PDESC_ZERO.wrongdec1.d
> +++ b/test/unittest/providers/err.D_PDESC_ZERO.wrongdec1.d
> @@ -4,7 +4,6 @@
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> -/* @@xfail: dtv2 */
>  
>  /*
>   * ASSERTION:
> diff --git a/test/unittest/providers/err.D_PDESC_ZERO.wrongdec2.d b/test/unittest/providers/err.D_PDESC_ZERO.wrongdec2.d
> index a17fb16e..9c8031b1 100644
> --- a/test/unittest/providers/err.D_PDESC_ZERO.wrongdec2.d
> +++ b/test/unittest/providers/err.D_PDESC_ZERO.wrongdec2.d
> @@ -4,7 +4,6 @@
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> -/* @@xfail: dtv2 */
>  
>  /*
>   * ASSERTION:
> diff --git a/test/unittest/providers/err.D_PDESC_ZERO.wrongdec3.d b/test/unittest/providers/err.D_PDESC_ZERO.wrongdec3.d
> index 5be89ada..e56a6847 100644
> --- a/test/unittest/providers/err.D_PDESC_ZERO.wrongdec3.d
> +++ b/test/unittest/providers/err.D_PDESC_ZERO.wrongdec3.d
> @@ -4,7 +4,6 @@
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> -/* @@xfail: dtv2 */
>  
>  /*
>   * ASSERTION:
> -- 
> 2.18.4
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel