[DTrace-devel] [PATCH] Remove obsolete dt_bpf_builtins.h header file

[Eugene Loh]

Reviewed-by: Eugene Loh <eugene.loh at oracle.com>


On 11/24/2020 01:51 PM, Kris Van Hees wrote:
> Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
> ---
>   libdtrace/dt_bpf_builtins.h | 47 -------------------------------------
>   libdtrace/dt_cg.c           |  1 -
>   libdtrace/dt_dis.c          |  1 -
>   libdtrace/dt_prov_fbt.c     |  1 -
>   libdtrace/dt_prov_sdt.c     |  1 -
>   libdtrace/dt_prov_syscall.c |  1 -
>   6 files changed, 52 deletions(-)
>   delete mode 100644 libdtrace/dt_bpf_builtins.h
>
> diff --git a/libdtrace/dt_bpf_builtins.h b/libdtrace/dt_bpf_builtins.h
> deleted file mode 100644
> index edf0333e..00000000
> --- a/libdtrace/dt_bpf_builtins.h
> +++ /dev/null
> @@ -1,47 +0,0 @@
> -/*
> - * Oracle Linux DTrace.
> - * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
> - * Licensed under the Universal Permissive License v 1.0 as shown at
> - * http://oss.oracle.com/licenses/upl.
> - */
> -
> -#ifndef _DT_BPF_BUILTINS_H
> -#define _DT_BPF_BUILTINS_H
> -
> -#ifdef FIXME
> -#ifdef  __cplusplus
> -extern "C" {
> -#endif
> -
> -#define DT_BPF_MAP_BUILTINS(FN) \
> -	FN(get_bvar), \
> -	FN(get_gvar), \
> -	FN(get_string), \
> -	FN(get_tvar), \
> -	FN(memcpy), \
> -	FN(set_gvar), \
> -	FN(set_tvar), \
> -	FN(strnlen)
> -
> -#define DT_BPF_ENUM_FN(x, y)	DT_BPF_ ## x
> -enum dt_bpf_builtin_ids {
> -        DT_BPF_MAP_BUILTINS(DT_BPF_ENUM_FN),
> -        DT_BPF_LAST_ID,
> -};
> -#undef DT_BPF_ENUM_FN
> -
> -typedef struct dt_bpf_func	dt_bpf_func_t;
> -typedef struct dt_bpf_builtin	dt_bpf_builtin_t;
> -struct dt_bpf_builtin {
> -	const char	*name;
> -	dt_bpf_func_t	*sym;
> -};
> -
> -extern dt_bpf_builtin_t		dt_bpf_builtins[];
> -
> -#ifdef  __cplusplus
> -}
> -#endif
> -#endif
> -
> -#endif /* _DT_BPF_FUNCS_H */
> diff --git a/libdtrace/dt_cg.c b/libdtrace/dt_cg.c
> index e03fc5ef..212f6753 100644
> --- a/libdtrace/dt_cg.c
> +++ b/libdtrace/dt_cg.c
> @@ -20,7 +20,6 @@
>   #include <dt_printf.h>
>   #include <dt_provider.h>
>   #include <dt_probe.h>
> -#include <dt_bpf_builtins.h>
>   #include <bpf_asm.h>
>   
>   static void dt_cg_node(dt_node_t *, dt_irlist_t *, dt_regset_t *);
> diff --git a/libdtrace/dt_dis.c b/libdtrace/dt_dis.c
> index b10c3867..d047bde3 100644
> --- a/libdtrace/dt_dis.c
> +++ b/libdtrace/dt_dis.c
> @@ -13,7 +13,6 @@
>   #include <dt_ident.h>
>   #include <dt_printf.h>
>   #include <dt_string.h>
> -#include <dt_bpf_builtins.h>
>   #include <bpf_asm.h>
>   #include <port.h>
>   
> diff --git a/libdtrace/dt_prov_fbt.c b/libdtrace/dt_prov_fbt.c
> index 3662306c..ad567c0a 100644
> --- a/libdtrace/dt_prov_fbt.c
> +++ b/libdtrace/dt_prov_fbt.c
> @@ -33,7 +33,6 @@
>   
>   #include "dt_dctx.h"
>   #include "dt_cg.h"
> -#include "dt_bpf_builtins.h"
>   #include "dt_provider.h"
>   #include "dt_probe.h"
>   #include "dt_pt_regs.h"
> diff --git a/libdtrace/dt_prov_sdt.c b/libdtrace/dt_prov_sdt.c
> index 3902e105..7e6525a5 100644
> --- a/libdtrace/dt_prov_sdt.c
> +++ b/libdtrace/dt_prov_sdt.c
> @@ -30,7 +30,6 @@
>   #include "dt_dctx.h"
>   #include "dt_cg.h"
>   #include "dt_bpf.h"
> -#include "dt_bpf_builtins.h"
>   #include "dt_provider.h"
>   #include "dt_probe.h"
>   #include "dt_pt_regs.h"
> diff --git a/libdtrace/dt_prov_syscall.c b/libdtrace/dt_prov_syscall.c
> index a548c9c8..5415dd4a 100644
> --- a/libdtrace/dt_prov_syscall.c
> +++ b/libdtrace/dt_prov_syscall.c
> @@ -31,7 +31,6 @@
>   
>   #include "dt_dctx.h"
>   #include "dt_cg.h"
> -#include "dt_bpf_builtins.h"
>   #include "dt_provider.h"
>   #include "dt_probe.h"
>   #include "dt_pt_regs.h"