[DTrace-devel] [PATCH 2/4] Fix comment in SDT provider about the probes we skip

[Kris Van Hees]

On Fri, May 29, 2020 at 08:10:38PM -0400, eugene.loh at oracle.com wrote:
> From: Eugene Loh <eugene.loh at oracle.com>
> 
> Signed-off-by: Eugene Loh <eugene.loh at oracle.com>
> ---
>  libdtrace/dt_prov_sdt.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/libdtrace/dt_prov_sdt.c b/libdtrace/dt_prov_sdt.c
> index bc9642f8..24ae6f5d 100644
> --- a/libdtrace/dt_prov_sdt.c
> +++ b/libdtrace/dt_prov_sdt.c
> @@ -224,10 +224,11 @@ done:
>  }
>  
>  /*
> - * The PROBE_LIST file lists all tracepoints in a <group>:<name> format.  When
> - * kprobes are registered on the system, they will appear in this list also as
> - * kprobes:<name>.  We need to ignore them because DTrace already accounts for
> - * them as FBT probes.
> + * The PROBE_LIST file lists all tracepoints in a <group>:<name> format.
> + * We need to ignore these groups:
> + *   - GROUP_FMT (created by other DTrace processes)

This actually refers to kprobes and uprobes created by *any* dtrace process,
especially our own because we do not want to register the same probe under two
different providers.

> + *   - kprobes and uprobes (created by other users)

No need to mention "(created by other users)" because even if DTrace created
any we would need to ignore them.

> + *   - syscalls (handled by a different provider)
>   */
>  static int populate(dtrace_hdl_t *dtp)
>  {
> -- 
> 2.18.2
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel