[DTrace-devel] [PATCH 41/47] Skip two arg-tests that are not testing what they claim

Kris Van Hees kris.van.hees at oracle.com
Sun May 3 20:18:15 PDT 2020


These tests claim to test accessing arg0 through arg8 from a profile
(presumably a profile probe is meant) but instead they attach to
syscall entry probes.  The results of the tests are not validated in
any way either.

Signed-off-by: Kris Van Hees <kris.van.hees at oracle.com>
---
 test/unittest/builtinvar/tst.arg0clause.d    | 1 +
 test/unittest/builtinvar/tst.arg1to8clause.d | 1 +
 2 files changed, 2 insertions(+)

diff --git a/test/unittest/builtinvar/tst.arg0clause.d b/test/unittest/builtinvar/tst.arg0clause.d
index 509e5f51..6352b1ac 100644
--- a/test/unittest/builtinvar/tst.arg0clause.d
+++ b/test/unittest/builtinvar/tst.arg0clause.d
@@ -4,6 +4,7 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
+/* @@skip: needs to be reworked */
 
 /*
  * ASSERTION:
diff --git a/test/unittest/builtinvar/tst.arg1to8clause.d b/test/unittest/builtinvar/tst.arg1to8clause.d
index 40a2c0ac..45adfc04 100644
--- a/test/unittest/builtinvar/tst.arg1to8clause.d
+++ b/test/unittest/builtinvar/tst.arg1to8clause.d
@@ -4,6 +4,7 @@
  * Licensed under the Universal Permissive License v 1.0 as shown at
  * http://oss.oracle.com/licenses/upl.
  */
+/* @@skip: needs to be reworked */
 
 /*
  * ASSERTION:
-- 
2.26.0




More information about the DTrace-devel mailing list